]> git.kernelconcepts.de Git - karo-tx-linux.git/blobdiff - drivers/gpu/drm/i915/intel_display.c
Merge tag 'v3.7-rc2' into drm-intel-next-queued
[karo-tx-linux.git] / drivers / gpu / drm / i915 / intel_display.c
index 682bd3729baf62369fc66d23434f058a643ffc78..338570c8e0dc5030f6fb7d73e4e13712a3152351 100644 (file)
@@ -380,7 +380,7 @@ static const intel_limit_t intel_limits_vlv_dac = {
 
 static const intel_limit_t intel_limits_vlv_hdmi = {
        .dot = { .min = 20000, .max = 165000 },
-       .vco = { .min = 5994000, .max = 4000000 },
+       .vco = { .min = 4000000, .max = 5994000},
        .n = { .min = 1, .max = 7 },
        .m = { .min = 60, .max = 300 }, /* guess */
        .m1 = { .min = 2, .max = 3 },
@@ -393,10 +393,10 @@ static const intel_limit_t intel_limits_vlv_hdmi = {
 };
 
 static const intel_limit_t intel_limits_vlv_dp = {
-       .dot = { .min = 162000, .max = 270000 },
-       .vco = { .min = 5994000, .max = 4000000 },
+       .dot = { .min = 25000, .max = 270000 },
+       .vco = { .min = 4000000, .max = 6000000 },
        .n = { .min = 1, .max = 7 },
-       .m = { .min = 60, .max = 300 }, /* guess */
+       .m = { .min = 22, .max = 450 },
        .m1 = { .min = 2, .max = 3 },
        .m2 = { .min = 11, .max = 156 },
        .p = { .min = 10, .max = 30 },
@@ -3218,6 +3218,9 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
                if (encoder->pre_enable)
                        encoder->pre_enable(encoder);
 
+       if (IS_HASWELL(dev))
+               intel_ddi_enable_pipe_clock(intel_crtc);
+
        /* Enable panel fitting for LVDS */
        if (dev_priv->pch_pf_size &&
            (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS) || HAS_eDP)) {
@@ -3236,6 +3239,11 @@ static void ironlake_crtc_enable(struct drm_crtc *crtc)
         */
        intel_crtc_load_lut(crtc);
 
+       if (IS_HASWELL(dev)) {
+               intel_ddi_set_pipe_settings(crtc);
+               intel_ddi_enable_pipe_func(crtc);
+       }
+
        intel_enable_pipe(dev_priv, pipe, is_pch_port);
        intel_enable_plane(dev_priv, plane, pipe);
 
@@ -3293,10 +3301,16 @@ static void ironlake_crtc_disable(struct drm_crtc *crtc)
 
        intel_disable_pipe(dev_priv, pipe);
 
+       if (IS_HASWELL(dev))
+               intel_ddi_disable_pipe_func(dev_priv, pipe);
+
        /* Disable PF */
        I915_WRITE(PF_CTL(pipe), 0);
        I915_WRITE(PF_WIN_SZ(pipe), 0);
 
+       if (IS_HASWELL(dev))
+               intel_ddi_disable_pipe_clock(intel_crtc);
+
        for_each_encoder_on_crtc(dev, crtc, encoder)
                if (encoder->post_disable)
                        encoder->post_disable(encoder);
@@ -3351,6 +3365,11 @@ static void ironlake_crtc_off(struct drm_crtc *crtc)
        intel_put_pch_pll(intel_crtc);
 }
 
+static void haswell_crtc_off(struct drm_crtc *crtc)
+{
+       intel_ddi_put_crtc_pll(crtc);
+}
+
 static void intel_crtc_dpms_overlay(struct intel_crtc *intel_crtc, bool enable)
 {
        if (!enable && intel_crtc->overlay) {
@@ -4050,7 +4069,7 @@ static void vlv_update_pll(struct drm_crtc *crtc,
                           struct drm_display_mode *mode,
                           struct drm_display_mode *adjusted_mode,
                           intel_clock_t *clock, intel_clock_t *reduced_clock,
-                          int refclk, int num_connectors)
+                          int num_connectors)
 {
        struct drm_device *dev = crtc->dev;
        struct drm_i915_private *dev_priv = dev->dev_private;
@@ -4058,9 +4077,19 @@ static void vlv_update_pll(struct drm_crtc *crtc,
        int pipe = intel_crtc->pipe;
        u32 dpll, mdiv, pdiv;
        u32 bestn, bestm1, bestm2, bestp1, bestp2;
-       bool is_hdmi;
+       bool is_sdvo;
+       u32 temp;
 
-       is_hdmi = intel_pipe_has_type(crtc, INTEL_OUTPUT_HDMI);
+       is_sdvo = intel_pipe_has_type(crtc, INTEL_OUTPUT_SDVO) ||
+               intel_pipe_has_type(crtc, INTEL_OUTPUT_HDMI);
+
+       dpll = DPLL_VGA_MODE_DIS;
+       dpll |= DPLL_EXT_BUFFER_ENABLE_VLV;
+       dpll |= DPLL_REFA_CLK_ENABLE_VLV;
+       dpll |= DPLL_INTEGRATED_CLOCK_VLV;
+
+       I915_WRITE(DPLL(pipe), dpll);
+       POSTING_READ(DPLL(pipe));
 
        bestn = clock->n;
        bestm1 = clock->m1;
@@ -4068,12 +4097,10 @@ static void vlv_update_pll(struct drm_crtc *crtc,
        bestp1 = clock->p1;
        bestp2 = clock->p2;
 
-       /* Enable DPIO clock input */
-       dpll = DPLL_EXT_BUFFER_ENABLE_VLV | DPLL_REFA_CLK_ENABLE_VLV |
-               DPLL_VGA_MODE_DIS | DPLL_INTEGRATED_CLOCK_VLV;
-       I915_WRITE(DPLL(pipe), dpll);
-       POSTING_READ(DPLL(pipe));
-
+       /*
+        * In Valleyview PLL and program lane counter registers are exposed
+        * through DPIO interface
+        */
        mdiv = ((bestm1 << DPIO_M1DIV_SHIFT) | (bestm2 & DPIO_M2DIV_MASK));
        mdiv |= ((bestp1 << DPIO_P1_SHIFT) | (bestp2 << DPIO_P2_SHIFT));
        mdiv |= ((bestn << DPIO_N_SHIFT));
@@ -4084,12 +4111,13 @@ static void vlv_update_pll(struct drm_crtc *crtc,
 
        intel_dpio_write(dev_priv, DPIO_CORE_CLK(pipe), 0x01000000);
 
-       pdiv = DPIO_REFSEL_OVERRIDE | (5 << DPIO_PLL_MODESEL_SHIFT) |
+       pdiv = (1 << DPIO_REFSEL_OVERRIDE) | (5 << DPIO_PLL_MODESEL_SHIFT) |
                (3 << DPIO_BIAS_CURRENT_CTL_SHIFT) | (1<<20) |
-               (8 << DPIO_DRIVER_CTL_SHIFT) | (5 << DPIO_CLK_BIAS_CTL_SHIFT);
+               (7 << DPIO_PLL_REFCLK_SEL_SHIFT) | (8 << DPIO_DRIVER_CTL_SHIFT) |
+               (5 << DPIO_CLK_BIAS_CTL_SHIFT);
        intel_dpio_write(dev_priv, DPIO_REFSFR(pipe), pdiv);
 
-       intel_dpio_write(dev_priv, DPIO_LFP_COEFF(pipe), 0x009f0051);
+       intel_dpio_write(dev_priv, DPIO_LFP_COEFF(pipe), 0x005f003b);
 
        dpll |= DPLL_VCO_ENABLE;
        I915_WRITE(DPLL(pipe), dpll);
@@ -4097,19 +4125,44 @@ static void vlv_update_pll(struct drm_crtc *crtc,
        if (wait_for(((I915_READ(DPLL(pipe)) & DPLL_LOCK_VLV) == DPLL_LOCK_VLV), 1))
                DRM_ERROR("DPLL %d failed to lock\n", pipe);
 
-       if (is_hdmi) {
-               u32 temp = intel_mode_get_pixel_multiplier(adjusted_mode);
+       intel_dpio_write(dev_priv, DPIO_FASTCLK_DISABLE, 0x620);
+
+       if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT))
+               intel_dp_set_m_n(crtc, mode, adjusted_mode);
 
+       I915_WRITE(DPLL(pipe), dpll);
+
+       /* Wait for the clocks to stabilize. */
+       POSTING_READ(DPLL(pipe));
+       udelay(150);
+
+       temp = 0;
+       if (is_sdvo) {
+               temp = intel_mode_get_pixel_multiplier(adjusted_mode);
                if (temp > 1)
                        temp = (temp - 1) << DPLL_MD_UDI_MULTIPLIER_SHIFT;
                else
                        temp = 0;
-
-               I915_WRITE(DPLL_MD(pipe), temp);
-               POSTING_READ(DPLL_MD(pipe));
        }
+       I915_WRITE(DPLL_MD(pipe), temp);
+       POSTING_READ(DPLL_MD(pipe));
 
-       intel_dpio_write(dev_priv, DPIO_FASTCLK_DISABLE, 0x641); /* ??? */
+       /* Now program lane control registers */
+       if(intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)
+                       || intel_pipe_has_type(crtc, INTEL_OUTPUT_HDMI))
+       {
+               temp = 0x1000C4;
+               if(pipe == 1)
+                       temp |= (1 << 21);
+               intel_dpio_write(dev_priv, DPIO_DATA_CHANNEL1, temp);
+       }
+       if(intel_pipe_has_type(crtc,INTEL_OUTPUT_EDP))
+       {
+               temp = 0x1000C4;
+               if(pipe == 1)
+                       temp |= (1 << 21);
+               intel_dpio_write(dev_priv, DPIO_DATA_CHANNEL2, temp);
+       }
 }
 
 static void i9xx_update_pll(struct drm_crtc *crtc,
@@ -4125,6 +4178,8 @@ static void i9xx_update_pll(struct drm_crtc *crtc,
        u32 dpll;
        bool is_sdvo;
 
+       i9xx_update_pll_dividers(crtc, clock, reduced_clock);
+
        is_sdvo = intel_pipe_has_type(crtc, INTEL_OUTPUT_SDVO) ||
                intel_pipe_has_type(crtc, INTEL_OUTPUT_HDMI);
 
@@ -4225,7 +4280,7 @@ static void i9xx_update_pll(struct drm_crtc *crtc,
 
 static void i8xx_update_pll(struct drm_crtc *crtc,
                            struct drm_display_mode *adjusted_mode,
-                           intel_clock_t *clock,
+                           intel_clock_t *clock, intel_clock_t *reduced_clock,
                            int num_connectors)
 {
        struct drm_device *dev = crtc->dev;
@@ -4234,6 +4289,8 @@ static void i8xx_update_pll(struct drm_crtc *crtc,
        int pipe = intel_crtc->pipe;
        u32 dpll;
 
+       i9xx_update_pll_dividers(crtc, clock, reduced_clock);
+
        dpll = DPLL_VGA_MODE_DIS;
 
        if (intel_pipe_has_type(crtc, INTEL_OUTPUT_LVDS)) {
@@ -4283,6 +4340,55 @@ static void i8xx_update_pll(struct drm_crtc *crtc,
        I915_WRITE(DPLL(pipe), dpll);
 }
 
+static void intel_set_pipe_timings(struct intel_crtc *intel_crtc,
+                                  struct drm_display_mode *mode,
+                                  struct drm_display_mode *adjusted_mode)
+{
+       struct drm_device *dev = intel_crtc->base.dev;
+       struct drm_i915_private *dev_priv = dev->dev_private;
+       enum pipe pipe = intel_crtc->pipe;
+       uint32_t vsyncshift;
+
+       if (!IS_GEN2(dev) && adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
+               /* the chip adds 2 halflines automatically */
+               adjusted_mode->crtc_vtotal -= 1;
+               adjusted_mode->crtc_vblank_end -= 1;
+               vsyncshift = adjusted_mode->crtc_hsync_start
+                            - adjusted_mode->crtc_htotal / 2;
+       } else {
+               vsyncshift = 0;
+       }
+
+       if (INTEL_INFO(dev)->gen > 3)
+               I915_WRITE(VSYNCSHIFT(pipe), vsyncshift);
+
+       I915_WRITE(HTOTAL(pipe),
+                  (adjusted_mode->crtc_hdisplay - 1) |
+                  ((adjusted_mode->crtc_htotal - 1) << 16));
+       I915_WRITE(HBLANK(pipe),
+                  (adjusted_mode->crtc_hblank_start - 1) |
+                  ((adjusted_mode->crtc_hblank_end - 1) << 16));
+       I915_WRITE(HSYNC(pipe),
+                  (adjusted_mode->crtc_hsync_start - 1) |
+                  ((adjusted_mode->crtc_hsync_end - 1) << 16));
+
+       I915_WRITE(VTOTAL(pipe),
+                  (adjusted_mode->crtc_vdisplay - 1) |
+                  ((adjusted_mode->crtc_vtotal - 1) << 16));
+       I915_WRITE(VBLANK(pipe),
+                  (adjusted_mode->crtc_vblank_start - 1) |
+                  ((adjusted_mode->crtc_vblank_end - 1) << 16));
+       I915_WRITE(VSYNC(pipe),
+                  (adjusted_mode->crtc_vsync_start - 1) |
+                  ((adjusted_mode->crtc_vsync_end - 1) << 16));
+
+       /* pipesrc controls the size that is scaled from, which should
+        * always be the user's requested size.
+        */
+       I915_WRITE(PIPESRC(pipe),
+                  ((mode->hdisplay - 1) << 16) | (mode->vdisplay - 1));
+}
+
 static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
                              struct drm_display_mode *mode,
                              struct drm_display_mode *adjusted_mode,
@@ -4296,7 +4402,7 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
        int plane = intel_crtc->plane;
        int refclk, num_connectors = 0;
        intel_clock_t clock, reduced_clock;
-       u32 dspcntr, pipeconf, vsyncshift;
+       u32 dspcntr, pipeconf;
        bool ok, has_reduced_clock = false, is_sdvo = false;
        bool is_lvds = false, is_tv = false, is_dp = false;
        struct intel_encoder *encoder;
@@ -4360,14 +4466,14 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
        if (is_sdvo && is_tv)
                i9xx_adjust_sdvo_tv_clock(adjusted_mode, &clock);
 
-       i9xx_update_pll_dividers(crtc, &clock, has_reduced_clock ?
-                                &reduced_clock : NULL);
-
        if (IS_GEN2(dev))
-               i8xx_update_pll(crtc, adjusted_mode, &clock, num_connectors);
+               i8xx_update_pll(crtc, adjusted_mode, &clock,
+                               has_reduced_clock ? &reduced_clock : NULL,
+                               num_connectors);
        else if (IS_VALLEYVIEW(dev))
-               vlv_update_pll(crtc, mode,adjusted_mode, &clock, NULL,
-                              refclk, num_connectors);
+               vlv_update_pll(crtc, mode, adjusted_mode, &clock,
+                               has_reduced_clock ? &reduced_clock : NULL,
+                               num_connectors);
        else
                i9xx_update_pll(crtc, mode, adjusted_mode, &clock,
                                has_reduced_clock ? &reduced_clock : NULL,
@@ -4408,6 +4514,14 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
                }
        }
 
+       if (IS_VALLEYVIEW(dev) && intel_pipe_has_type(crtc, INTEL_OUTPUT_EDP)) {
+               if (adjusted_mode->private_flags & INTEL_MODE_DP_FORCE_6BPC) {
+                       pipeconf |= PIPECONF_BPP_6 |
+                                       PIPECONF_ENABLE |
+                                       I965_PIPECONF_ACTIVE;
+               }
+       }
+
        DRM_DEBUG_KMS("Mode for pipe %c:\n", pipe == 0 ? 'A' : 'B');
        drm_mode_debug_printmodeline(mode);
 
@@ -4423,40 +4537,12 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
 
        pipeconf &= ~PIPECONF_INTERLACE_MASK;
        if (!IS_GEN2(dev) &&
-           adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
+           adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
                pipeconf |= PIPECONF_INTERLACE_W_FIELD_INDICATION;
-               /* the chip adds 2 halflines automatically */
-               adjusted_mode->crtc_vtotal -= 1;
-               adjusted_mode->crtc_vblank_end -= 1;
-               vsyncshift = adjusted_mode->crtc_hsync_start
-                            - adjusted_mode->crtc_htotal/2;
-       } else {
+       else
                pipeconf |= PIPECONF_PROGRESSIVE;
-               vsyncshift = 0;
-       }
-
-       if (!IS_GEN3(dev))
-               I915_WRITE(VSYNCSHIFT(pipe), vsyncshift);
-
-       I915_WRITE(HTOTAL(pipe),
-                  (adjusted_mode->crtc_hdisplay - 1) |
-                  ((adjusted_mode->crtc_htotal - 1) << 16));
-       I915_WRITE(HBLANK(pipe),
-                  (adjusted_mode->crtc_hblank_start - 1) |
-                  ((adjusted_mode->crtc_hblank_end - 1) << 16));
-       I915_WRITE(HSYNC(pipe),
-                  (adjusted_mode->crtc_hsync_start - 1) |
-                  ((adjusted_mode->crtc_hsync_end - 1) << 16));
 
-       I915_WRITE(VTOTAL(pipe),
-                  (adjusted_mode->crtc_vdisplay - 1) |
-                  ((adjusted_mode->crtc_vtotal - 1) << 16));
-       I915_WRITE(VBLANK(pipe),
-                  (adjusted_mode->crtc_vblank_start - 1) |
-                  ((adjusted_mode->crtc_vblank_end - 1) << 16));
-       I915_WRITE(VSYNC(pipe),
-                  (adjusted_mode->crtc_vsync_start - 1) |
-                  ((adjusted_mode->crtc_vsync_end - 1) << 16));
+       intel_set_pipe_timings(intel_crtc, mode, adjusted_mode);
 
        /* pipesrc and dspsize control the size that is scaled from,
         * which should always be the user's requested size.
@@ -4465,8 +4551,6 @@ static int i9xx_crtc_mode_set(struct drm_crtc *crtc,
                   ((mode->vdisplay - 1) << 16) |
                   (mode->hdisplay - 1));
        I915_WRITE(DSPPOS(plane), 0);
-       I915_WRITE(PIPESRC(pipe),
-                  ((mode->hdisplay - 1) << 16) | (mode->vdisplay - 1));
 
        I915_WRITE(PIPECONF(pipe), pipeconf);
        POSTING_READ(PIPECONF(pipe));
@@ -4657,8 +4741,8 @@ static void ironlake_set_pipeconf(struct drm_crtc *crtc,
                val |= PIPE_12BPC;
                break;
        default:
-               val |= PIPE_8BPC;
-               break;
+               /* Case prevented by intel_choose_pipe_bpp_dither. */
+               BUG();
        }
 
        val &= ~(PIPECONF_DITHER_EN | PIPECONF_DITHER_TYPE_MASK);
@@ -4675,6 +4759,31 @@ static void ironlake_set_pipeconf(struct drm_crtc *crtc,
        POSTING_READ(PIPECONF(pipe));
 }
 
+static void haswell_set_pipeconf(struct drm_crtc *crtc,
+                                struct drm_display_mode *adjusted_mode,
+                                bool dither)
+{
+       struct drm_i915_private *dev_priv = crtc->dev->dev_private;
+       struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+       int pipe = intel_crtc->pipe;
+       uint32_t val;
+
+       val = I915_READ(PIPECONF(pipe));
+
+       val &= ~(PIPECONF_DITHER_EN | PIPECONF_DITHER_TYPE_MASK);
+       if (dither)
+               val |= (PIPECONF_DITHER_EN | PIPECONF_DITHER_TYPE_SP);
+
+       val &= ~PIPECONF_INTERLACE_MASK_HSW;
+       if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE)
+               val |= PIPECONF_INTERLACED_ILK;
+       else
+               val |= PIPECONF_PROGRESSIVE;
+
+       I915_WRITE(PIPECONF(pipe), val);
+       POSTING_READ(PIPECONF(pipe));
+}
+
 static bool ironlake_compute_clocks(struct drm_crtc *crtc,
                                    struct drm_display_mode *adjusted_mode,
                                    intel_clock_t *clock,
@@ -4738,74 +4847,33 @@ static bool ironlake_compute_clocks(struct drm_crtc *crtc,
        return true;
 }
 
-static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
-                                 struct drm_display_mode *mode,
-                                 struct drm_display_mode *adjusted_mode,
-                                 int x, int y,
-                                 struct drm_framebuffer *fb)
+static void ironlake_set_m_n(struct drm_crtc *crtc,
+                            struct drm_display_mode *mode,
+                            struct drm_display_mode *adjusted_mode)
 {
        struct drm_device *dev = crtc->dev;
        struct drm_i915_private *dev_priv = dev->dev_private;
        struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
-       int pipe = intel_crtc->pipe;
-       int plane = intel_crtc->plane;
-       int num_connectors = 0;
-       intel_clock_t clock, reduced_clock;
-       u32 dpll, fp = 0, fp2 = 0;
-       bool ok, has_reduced_clock = false, is_sdvo = false;
-       bool is_crt = false, is_lvds = false, is_tv = false, is_dp = false;
-       struct intel_encoder *encoder, *edp_encoder = NULL;
-       int ret;
+       enum pipe pipe = intel_crtc->pipe;
+       struct intel_encoder *intel_encoder, *edp_encoder = NULL;
        struct fdi_m_n m_n = {0};
-       u32 temp;
-       int target_clock, pixel_multiplier, lane, link_bw, factor;
-       unsigned int pipe_bpp;
-       bool dither;
-       bool is_cpu_edp = false, is_pch_edp = false;
+       int target_clock, pixel_multiplier, lane, link_bw;
+       bool is_dp = false, is_cpu_edp = false;
 
-       for_each_encoder_on_crtc(dev, crtc, encoder) {
-               switch (encoder->type) {
-               case INTEL_OUTPUT_LVDS:
-                       is_lvds = true;
-                       break;
-               case INTEL_OUTPUT_SDVO:
-               case INTEL_OUTPUT_HDMI:
-                       is_sdvo = true;
-                       if (encoder->needs_tv_clock)
-                               is_tv = true;
-                       break;
-               case INTEL_OUTPUT_TVOUT:
-                       is_tv = true;
-                       break;
-               case INTEL_OUTPUT_ANALOG:
-                       is_crt = true;
-                       break;
+       for_each_encoder_on_crtc(dev, crtc, intel_encoder) {
+               switch (intel_encoder->type) {
                case INTEL_OUTPUT_DISPLAYPORT:
                        is_dp = true;
                        break;
                case INTEL_OUTPUT_EDP:
                        is_dp = true;
-                       if (intel_encoder_is_pch_edp(&encoder->base))
-                               is_pch_edp = true;
-                       else
+                       if (!intel_encoder_is_pch_edp(&intel_encoder->base))
                                is_cpu_edp = true;
-                       edp_encoder = encoder;
+                       edp_encoder = intel_encoder;
                        break;
                }
-
-               num_connectors++;
-       }
-
-       ok = ironlake_compute_clocks(crtc, adjusted_mode, &clock,
-                                    &has_reduced_clock, &reduced_clock);
-       if (!ok) {
-               DRM_ERROR("Couldn't find PLL settings for mode!\n");
-               return -EINVAL;
        }
 
-       /* Ensure that the cursor is valid for the new mode before changing... */
-       intel_crtc_update_cursor(crtc, true);
-
        /* FDI link */
        pixel_multiplier = intel_mode_get_pixel_multiplier(adjusted_mode);
        lane = 0;
@@ -4832,20 +4900,6 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
        else
                target_clock = adjusted_mode->clock;
 
-       /* determine panel color depth */
-       dither = intel_choose_pipe_bpp_dither(crtc, fb, &pipe_bpp,
-                                             adjusted_mode);
-       if (is_lvds && dev_priv->lvds_dither)
-               dither = true;
-
-       if (pipe_bpp != 18 && pipe_bpp != 24 && pipe_bpp != 30 &&
-           pipe_bpp != 36) {
-               WARN(1, "intel_choose_pipe_bpp returned invalid value %d\n",
-                    pipe_bpp);
-               pipe_bpp = 24;
-       }
-       intel_crtc->bpp = pipe_bpp;
-
        if (!lane) {
                /*
                 * Account for spread spectrum to avoid
@@ -4863,10 +4917,51 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
        ironlake_compute_m_n(intel_crtc->bpp, lane, target_clock, link_bw,
                             &m_n);
 
-       fp = clock.n << 16 | clock.m1 << 8 | clock.m2;
-       if (has_reduced_clock)
-               fp2 = reduced_clock.n << 16 | reduced_clock.m1 << 8 |
-                       reduced_clock.m2;
+       I915_WRITE(PIPE_DATA_M1(pipe), TU_SIZE(m_n.tu) | m_n.gmch_m);
+       I915_WRITE(PIPE_DATA_N1(pipe), m_n.gmch_n);
+       I915_WRITE(PIPE_LINK_M1(pipe), m_n.link_m);
+       I915_WRITE(PIPE_LINK_N1(pipe), m_n.link_n);
+}
+
+static uint32_t ironlake_compute_dpll(struct intel_crtc *intel_crtc,
+                                     struct drm_display_mode *adjusted_mode,
+                                     intel_clock_t *clock, u32 fp)
+{
+       struct drm_crtc *crtc = &intel_crtc->base;
+       struct drm_device *dev = crtc->dev;
+       struct drm_i915_private *dev_priv = dev->dev_private;
+       struct intel_encoder *intel_encoder;
+       uint32_t dpll;
+       int factor, pixel_multiplier, num_connectors = 0;
+       bool is_lvds = false, is_sdvo = false, is_tv = false;
+       bool is_dp = false, is_cpu_edp = false;
+
+       for_each_encoder_on_crtc(dev, crtc, intel_encoder) {
+               switch (intel_encoder->type) {
+               case INTEL_OUTPUT_LVDS:
+                       is_lvds = true;
+                       break;
+               case INTEL_OUTPUT_SDVO:
+               case INTEL_OUTPUT_HDMI:
+                       is_sdvo = true;
+                       if (intel_encoder->needs_tv_clock)
+                               is_tv = true;
+                       break;
+               case INTEL_OUTPUT_TVOUT:
+                       is_tv = true;
+                       break;
+               case INTEL_OUTPUT_DISPLAYPORT:
+                       is_dp = true;
+                       break;
+               case INTEL_OUTPUT_EDP:
+                       is_dp = true;
+                       if (!intel_encoder_is_pch_edp(&intel_encoder->base))
+                               is_cpu_edp = true;
+                       break;
+               }
+
+               num_connectors++;
+       }
 
        /* Enable autotuning of the PLL clock (if permissible) */
        factor = 21;
@@ -4878,7 +4973,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
        } else if (is_sdvo && is_tv)
                factor = 20;
 
-       if (clock.m < factor * clock.n)
+       if (clock->m < factor * clock->n)
                fp |= FP_CB_TUNE;
 
        dpll = 0;
@@ -4888,7 +4983,7 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
        else
                dpll |= DPLLB_MODE_DAC_SERIAL;
        if (is_sdvo) {
-               int pixel_multiplier = intel_mode_get_pixel_multiplier(adjusted_mode);
+               pixel_multiplier = intel_mode_get_pixel_multiplier(adjusted_mode);
                if (pixel_multiplier > 1) {
                        dpll |= (pixel_multiplier - 1) << PLL_REF_SDVO_HDMI_MULTIPLIER_SHIFT;
                }
@@ -4898,11 +4993,11 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
                dpll |= DPLL_DVO_HIGH_SPEED;
 
        /* compute bitmask from p1 value */
-       dpll |= (1 << (clock.p1 - 1)) << DPLL_FPA01_P1_POST_DIV_SHIFT;
+       dpll |= (1 << (clock->p1 - 1)) << DPLL_FPA01_P1_POST_DIV_SHIFT;
        /* also FPA1 */
-       dpll |= (1 << (clock.p1 - 1)) << DPLL_FPA1_P1_POST_DIV_SHIFT;
+       dpll |= (1 << (clock->p1 - 1)) << DPLL_FPA1_P1_POST_DIV_SHIFT;
 
-       switch (clock.p2) {
+       switch (clock->p2) {
        case 5:
                dpll |= DPLL_DAC_SERIAL_P2_CLOCK_DIV_5;
                break;
@@ -4928,15 +5023,78 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
        else
                dpll |= PLL_REF_INPUT_DREFCLK;
 
+       return dpll;
+}
+
+static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
+                                 struct drm_display_mode *mode,
+                                 struct drm_display_mode *adjusted_mode,
+                                 int x, int y,
+                                 struct drm_framebuffer *fb)
+{
+       struct drm_device *dev = crtc->dev;
+       struct drm_i915_private *dev_priv = dev->dev_private;
+       struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+       int pipe = intel_crtc->pipe;
+       int plane = intel_crtc->plane;
+       int num_connectors = 0;
+       intel_clock_t clock, reduced_clock;
+       u32 dpll, fp = 0, fp2 = 0;
+       bool ok, has_reduced_clock = false;
+       bool is_lvds = false, is_dp = false, is_cpu_edp = false;
+       struct intel_encoder *encoder;
+       u32 temp;
+       int ret;
+       bool dither;
+
+       for_each_encoder_on_crtc(dev, crtc, encoder) {
+               switch (encoder->type) {
+               case INTEL_OUTPUT_LVDS:
+                       is_lvds = true;
+                       break;
+               case INTEL_OUTPUT_DISPLAYPORT:
+                       is_dp = true;
+                       break;
+               case INTEL_OUTPUT_EDP:
+                       is_dp = true;
+                       if (!intel_encoder_is_pch_edp(&encoder->base))
+                               is_cpu_edp = true;
+                       break;
+               }
+
+               num_connectors++;
+       }
+
+       WARN(!(HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)),
+            "Unexpected PCH type %d\n", INTEL_PCH_TYPE(dev));
+
+       ok = ironlake_compute_clocks(crtc, adjusted_mode, &clock,
+                                    &has_reduced_clock, &reduced_clock);
+       if (!ok) {
+               DRM_ERROR("Couldn't find PLL settings for mode!\n");
+               return -EINVAL;
+       }
+
+       /* Ensure that the cursor is valid for the new mode before changing... */
+       intel_crtc_update_cursor(crtc, true);
+
+       /* determine panel color depth */
+       dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode);
+       if (is_lvds && dev_priv->lvds_dither)
+               dither = true;
+
+       fp = clock.n << 16 | clock.m1 << 8 | clock.m2;
+       if (has_reduced_clock)
+               fp2 = reduced_clock.n << 16 | reduced_clock.m1 << 8 |
+                       reduced_clock.m2;
+
+       dpll = ironlake_compute_dpll(intel_crtc, adjusted_mode, &clock, fp);
+
        DRM_DEBUG_KMS("Mode for pipe %d:\n", pipe);
        drm_mode_debug_printmodeline(mode);
 
-       /* CPU eDP is the only output that doesn't need a PCH PLL of its own on
-        * pre-Haswell/LPT generation */
-       if (HAS_PCH_LPT(dev)) {
-               DRM_DEBUG_KMS("LPT detected: no PLL for pipe %d necessary\n",
-                               pipe);
-       } else if (!is_cpu_edp) {
+       /* CPU eDP is the only output that doesn't need a PCH PLL of its own. */
+       if (!is_cpu_edp) {
                struct intel_pch_pll *pll;
 
                pll = intel_get_pch_pll(intel_crtc, dpll, fp);
@@ -5022,47 +5180,9 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
                }
        }
 
-       if (adjusted_mode->flags & DRM_MODE_FLAG_INTERLACE) {
-               /* the chip adds 2 halflines automatically */
-               adjusted_mode->crtc_vtotal -= 1;
-               adjusted_mode->crtc_vblank_end -= 1;
-               I915_WRITE(VSYNCSHIFT(pipe),
-                          adjusted_mode->crtc_hsync_start
-                          - adjusted_mode->crtc_htotal/2);
-       } else {
-               I915_WRITE(VSYNCSHIFT(pipe), 0);
-       }
-
-       I915_WRITE(HTOTAL(pipe),
-                  (adjusted_mode->crtc_hdisplay - 1) |
-                  ((adjusted_mode->crtc_htotal - 1) << 16));
-       I915_WRITE(HBLANK(pipe),
-                  (adjusted_mode->crtc_hblank_start - 1) |
-                  ((adjusted_mode->crtc_hblank_end - 1) << 16));
-       I915_WRITE(HSYNC(pipe),
-                  (adjusted_mode->crtc_hsync_start - 1) |
-                  ((adjusted_mode->crtc_hsync_end - 1) << 16));
-
-       I915_WRITE(VTOTAL(pipe),
-                  (adjusted_mode->crtc_vdisplay - 1) |
-                  ((adjusted_mode->crtc_vtotal - 1) << 16));
-       I915_WRITE(VBLANK(pipe),
-                  (adjusted_mode->crtc_vblank_start - 1) |
-                  ((adjusted_mode->crtc_vblank_end - 1) << 16));
-       I915_WRITE(VSYNC(pipe),
-                  (adjusted_mode->crtc_vsync_start - 1) |
-                  ((adjusted_mode->crtc_vsync_end - 1) << 16));
-
-       /* pipesrc controls the size that is scaled from, which should
-        * always be the user's requested size.
-        */
-       I915_WRITE(PIPESRC(pipe),
-                  ((mode->hdisplay - 1) << 16) | (mode->vdisplay - 1));
+       intel_set_pipe_timings(intel_crtc, mode, adjusted_mode);
 
-       I915_WRITE(PIPE_DATA_M1(pipe), TU_SIZE(m_n.tu) | m_n.gmch_m);
-       I915_WRITE(PIPE_DATA_N1(pipe), m_n.gmch_n);
-       I915_WRITE(PIPE_LINK_M1(pipe), m_n.link_m);
-       I915_WRITE(PIPE_LINK_N1(pipe), m_n.link_n);
+       ironlake_set_m_n(crtc, mode, adjusted_mode);
 
        if (is_cpu_edp)
                ironlake_set_pll_edp(crtc, adjusted_mode->clock);
@@ -5084,6 +5204,211 @@ static int ironlake_crtc_mode_set(struct drm_crtc *crtc,
        return ret;
 }
 
+static int haswell_crtc_mode_set(struct drm_crtc *crtc,
+                                struct drm_display_mode *mode,
+                                struct drm_display_mode *adjusted_mode,
+                                int x, int y,
+                                struct drm_framebuffer *fb)
+{
+       struct drm_device *dev = crtc->dev;
+       struct drm_i915_private *dev_priv = dev->dev_private;
+       struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
+       int pipe = intel_crtc->pipe;
+       int plane = intel_crtc->plane;
+       int num_connectors = 0;
+       intel_clock_t clock, reduced_clock;
+       u32 dpll = 0, fp = 0, fp2 = 0;
+       bool ok, has_reduced_clock = false;
+       bool is_lvds = false, is_dp = false, is_cpu_edp = false;
+       struct intel_encoder *encoder;
+       u32 temp;
+       int ret;
+       bool dither;
+
+       for_each_encoder_on_crtc(dev, crtc, encoder) {
+               switch (encoder->type) {
+               case INTEL_OUTPUT_LVDS:
+                       is_lvds = true;
+                       break;
+               case INTEL_OUTPUT_DISPLAYPORT:
+                       is_dp = true;
+                       break;
+               case INTEL_OUTPUT_EDP:
+                       is_dp = true;
+                       if (!intel_encoder_is_pch_edp(&encoder->base))
+                               is_cpu_edp = true;
+                       break;
+               }
+
+               num_connectors++;
+       }
+
+       /* We are not sure yet this won't happen. */
+       WARN(!HAS_PCH_LPT(dev), "Unexpected PCH type %d\n",
+            INTEL_PCH_TYPE(dev));
+
+       WARN(num_connectors != 1, "%d connectors attached to pipe %c\n",
+            num_connectors, pipe_name(pipe));
+
+       WARN_ON(I915_READ(PIPECONF(pipe)) &
+               (PIPECONF_ENABLE | I965_PIPECONF_ACTIVE));
+
+       WARN_ON(I915_READ(DSPCNTR(plane)) & DISPLAY_PLANE_ENABLE);
+
+       if (!intel_ddi_pll_mode_set(crtc, adjusted_mode->clock))
+               return -EINVAL;
+
+       if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) {
+               ok = ironlake_compute_clocks(crtc, adjusted_mode, &clock,
+                                            &has_reduced_clock,
+                                            &reduced_clock);
+               if (!ok) {
+                       DRM_ERROR("Couldn't find PLL settings for mode!\n");
+                       return -EINVAL;
+               }
+       }
+
+       /* Ensure that the cursor is valid for the new mode before changing... */
+       intel_crtc_update_cursor(crtc, true);
+
+       /* determine panel color depth */
+       dither = intel_choose_pipe_bpp_dither(crtc, fb, &intel_crtc->bpp, mode);
+       if (is_lvds && dev_priv->lvds_dither)
+               dither = true;
+
+       DRM_DEBUG_KMS("Mode for pipe %d:\n", pipe);
+       drm_mode_debug_printmodeline(mode);
+
+       if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) {
+               fp = clock.n << 16 | clock.m1 << 8 | clock.m2;
+               if (has_reduced_clock)
+                       fp2 = reduced_clock.n << 16 | reduced_clock.m1 << 8 |
+                             reduced_clock.m2;
+
+               dpll = ironlake_compute_dpll(intel_crtc, adjusted_mode, &clock,
+                                            fp);
+
+               /* CPU eDP is the only output that doesn't need a PCH PLL of its
+                * own on pre-Haswell/LPT generation */
+               if (!is_cpu_edp) {
+                       struct intel_pch_pll *pll;
+
+                       pll = intel_get_pch_pll(intel_crtc, dpll, fp);
+                       if (pll == NULL) {
+                               DRM_DEBUG_DRIVER("failed to find PLL for pipe %d\n",
+                                                pipe);
+                               return -EINVAL;
+                       }
+               } else
+                       intel_put_pch_pll(intel_crtc);
+
+               /* The LVDS pin pair needs to be on before the DPLLs are
+                * enabled.  This is an exception to the general rule that
+                * mode_set doesn't turn things on.
+                */
+               if (is_lvds) {
+                       temp = I915_READ(PCH_LVDS);
+                       temp |= LVDS_PORT_EN | LVDS_A0A2_CLKA_POWER_UP;
+                       if (HAS_PCH_CPT(dev)) {
+                               temp &= ~PORT_TRANS_SEL_MASK;
+                               temp |= PORT_TRANS_SEL_CPT(pipe);
+                       } else {
+                               if (pipe == 1)
+                                       temp |= LVDS_PIPEB_SELECT;
+                               else
+                                       temp &= ~LVDS_PIPEB_SELECT;
+                       }
+
+                       /* set the corresponsding LVDS_BORDER bit */
+                       temp |= dev_priv->lvds_border_bits;
+                       /* Set the B0-B3 data pairs corresponding to whether
+                        * we're going to set the DPLLs for dual-channel mode or
+                        * not.
+                        */
+                       if (clock.p2 == 7)
+                               temp |= LVDS_B0B3_POWER_UP | LVDS_CLKB_POWER_UP;
+                       else
+                               temp &= ~(LVDS_B0B3_POWER_UP |
+                                         LVDS_CLKB_POWER_UP);
+
+                       /* It would be nice to set 24 vs 18-bit mode
+                        * (LVDS_A3_POWER_UP) appropriately here, but we need to
+                        * look more thoroughly into how panels behave in the
+                        * two modes.
+                        */
+                       temp &= ~(LVDS_HSYNC_POLARITY | LVDS_VSYNC_POLARITY);
+                       if (adjusted_mode->flags & DRM_MODE_FLAG_NHSYNC)
+                               temp |= LVDS_HSYNC_POLARITY;
+                       if (adjusted_mode->flags & DRM_MODE_FLAG_NVSYNC)
+                               temp |= LVDS_VSYNC_POLARITY;
+                       I915_WRITE(PCH_LVDS, temp);
+               }
+       }
+
+       if (is_dp && !is_cpu_edp) {
+               intel_dp_set_m_n(crtc, mode, adjusted_mode);
+       } else {
+               if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) {
+                       /* For non-DP output, clear any trans DP clock recovery
+                        * setting.*/
+                       I915_WRITE(TRANSDATA_M1(pipe), 0);
+                       I915_WRITE(TRANSDATA_N1(pipe), 0);
+                       I915_WRITE(TRANSDPLINK_M1(pipe), 0);
+                       I915_WRITE(TRANSDPLINK_N1(pipe), 0);
+               }
+       }
+
+       intel_crtc->lowfreq_avail = false;
+       if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev)) {
+               if (intel_crtc->pch_pll) {
+                       I915_WRITE(intel_crtc->pch_pll->pll_reg, dpll);
+
+                       /* Wait for the clocks to stabilize. */
+                       POSTING_READ(intel_crtc->pch_pll->pll_reg);
+                       udelay(150);
+
+                       /* The pixel multiplier can only be updated once the
+                        * DPLL is enabled and the clocks are stable.
+                        *
+                        * So write it again.
+                        */
+                       I915_WRITE(intel_crtc->pch_pll->pll_reg, dpll);
+               }
+
+               if (intel_crtc->pch_pll) {
+                       if (is_lvds && has_reduced_clock && i915_powersave) {
+                               I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp2);
+                               intel_crtc->lowfreq_avail = true;
+                       } else {
+                               I915_WRITE(intel_crtc->pch_pll->fp1_reg, fp);
+                       }
+               }
+       }
+
+       intel_set_pipe_timings(intel_crtc, mode, adjusted_mode);
+
+       if (!is_dp || is_cpu_edp)
+               ironlake_set_m_n(crtc, mode, adjusted_mode);
+
+       if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
+               if (is_cpu_edp)
+                       ironlake_set_pll_edp(crtc, adjusted_mode->clock);
+
+       haswell_set_pipeconf(crtc, adjusted_mode, dither);
+
+       /* Set up the display plane register */
+       I915_WRITE(DSPCNTR(plane), DISPPLANE_GAMMA_ENABLE);
+       POSTING_READ(DSPCNTR(plane));
+
+       ret = intel_pipe_set_base(crtc, x, y, fb);
+
+       intel_update_watermarks(dev);
+
+       intel_update_linetime_watermarks(dev, pipe, adjusted_mode);
+
+       return ret;
+}
+
 static int intel_crtc_mode_set(struct drm_crtc *crtc,
                               struct drm_display_mode *mode,
                               struct drm_display_mode *adjusted_mode,
@@ -7409,6 +7734,12 @@ static const struct drm_crtc_funcs intel_crtc_funcs = {
        .page_flip = intel_crtc_page_flip,
 };
 
+static void intel_cpu_pll_init(struct drm_device *dev)
+{
+       if (IS_HASWELL(dev))
+               intel_ddi_pll_init(dev);
+}
+
 static void intel_pch_pll_init(struct drm_device *dev)
 {
        drm_i915_private_t *dev_priv = dev->dev_private;
@@ -7597,6 +7928,10 @@ static void intel_setup_outputs(struct drm_device *dev)
        } else if (IS_VALLEYVIEW(dev)) {
                int found;
 
+               /* Check for built-in panel first. Shares lanes with HDMI on SDVOC */
+               if (I915_READ(DP_C) & DP_DETECTED)
+                       intel_dp_init(dev, DP_C, PORT_C);
+
                if (I915_READ(SDVOB) & PORT_DETECTED) {
                        /* SDVOB multiplex with HDMIB */
                        found = intel_sdvo_init(dev, SDVOB, true);
@@ -7609,9 +7944,6 @@ static void intel_setup_outputs(struct drm_device *dev)
                if (I915_READ(SDVOC) & PORT_DETECTED)
                        intel_hdmi_init(dev, SDVOC, PORT_C);
 
-               /* Shares lanes with HDMI on SDVOC */
-               if (I915_READ(DP_C) & DP_DETECTED)
-                       intel_dp_init(dev, DP_C, PORT_C);
        } else if (SUPPORTS_DIGITAL_OUTPUTS(dev)) {
                bool found = false;
 
@@ -7765,7 +8097,13 @@ static void intel_init_display(struct drm_device *dev)
        struct drm_i915_private *dev_priv = dev->dev_private;
 
        /* We always want a DPMS function */
-       if (HAS_PCH_SPLIT(dev)) {
+       if (IS_HASWELL(dev)) {
+               dev_priv->display.crtc_mode_set = haswell_crtc_mode_set;
+               dev_priv->display.crtc_enable = ironlake_crtc_enable;
+               dev_priv->display.crtc_disable = ironlake_crtc_disable;
+               dev_priv->display.off = haswell_crtc_off;
+               dev_priv->display.update_plane = ironlake_update_plane;
+       } else if (HAS_PCH_SPLIT(dev)) {
                dev_priv->display.crtc_mode_set = ironlake_crtc_mode_set;
                dev_priv->display.crtc_enable = ironlake_crtc_enable;
                dev_priv->display.crtc_disable = ironlake_crtc_disable;
@@ -8015,6 +8353,7 @@ void intel_modeset_init(struct drm_device *dev)
                        DRM_DEBUG_KMS("plane %d init failed: %d\n", i, ret);
        }
 
+       intel_cpu_pll_init(dev);
        intel_pch_pll_init(dev);
 
        /* Just disable it once at startup */
@@ -8228,6 +8567,9 @@ void intel_modeset_setup_hw_state(struct drm_device *dev)
                              crtc->active ? "enabled" : "disabled");
        }
 
+       if (IS_HASWELL(dev))
+               intel_ddi_setup_hw_pll_state(dev);
+
        list_for_each_entry(encoder, &dev->mode_config.encoder_list,
                            base.head) {
                pipe = 0;
@@ -8277,6 +8619,8 @@ void intel_modeset_setup_hw_state(struct drm_device *dev)
        intel_modeset_update_staged_output_state(dev);
 
        intel_modeset_check_state(dev);
+
+       drm_mode_config_reset(dev);
 }
 
 void intel_modeset_gem_init(struct drm_device *dev)