]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
bnx2x: fix occasional statistics off-by-4GB error
authorMaciej Żenczykowski <maze@google.com>
Fri, 15 Mar 2013 11:56:17 +0000 (11:56 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Mar 2013 19:11:54 +0000 (12:11 -0700)
commit05bec9da3978124bde3b40bfa0404760f45aa399
tree0fd1cf90efad6fd3ca2f00862eaae47a1bfce229
parentc2abe8ada7b63b6ede9c80e615fdbc97dde2e2e2
bnx2x: fix occasional statistics off-by-4GB error

[ Upstream commit b009aac12cd0fe34293c68af8ac48b85be3bd858 ]

The UPDATE_QSTAT function introduced on February 15, 2012
in commit 1355b704b9ba "bnx2x: consistent statistics after
internal driver reload" incorrectly fails to handle overflow
during addition of the lower 32-bit field of a stat.

This bug is present since 3.4-rc1 and should thus be considered
a candidate for stable 3.4+ releases.

Google-Bug-Id: 8374428
Signed-off-by: Maciej Żenczykowski <maze@google.com>
Cc: Mintz Yuval <yuvalmin@broadcom.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.h