]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mtd: nand: reintroduce NAND_NO_READRDY as NAND_NEED_READRDY
authorBrian Norris <computersforpeace@gmail.com>
Wed, 13 Mar 2013 16:51:31 +0000 (09:51 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2013 20:10:56 +0000 (13:10 -0700)
commit06aaf3b3a033032d9475eebe1cbcfb6136dbfd23
tree568c504427ba256ecbe1c5fd8d45485553cca8dc
parentb3225f59a651408f57db4a49238113384dc7c873
mtd: nand: reintroduce NAND_NO_READRDY as NAND_NEED_READRDY

commit 5bc7c33ca93a285dcfe7b7fd64970f6314440ad1 upstream.

This partially reverts commit 1696e6bc2ae83734e64e206ac99766ea19e9a14e
("mtd: nand: kill NAND_NO_READRDY").

In that patch I overlooked a few things.

The original documentation for NAND_NO_READRDY included "True for all
large page devices, as they do not support autoincrement." I was
conflating "not support autoincrement" with the NAND_NO_AUTOINCR option,
which was in fact doing nothing. So, when I dropped NAND_NO_AUTOINCR, I
concluded that I then could harmlessly drop NAND_NO_READRDY. But of
course the fact the NAND_NO_AUTOINCR was doing nothing didn't mean
NAND_NO_READRDY was doing nothing...

So, NAND_NO_READRDY is re-introduced as NAND_NEED_READRDY and applied
only to those few remaining small-page NAND which needed it in the first
place.

Reported-by: Alexander Shiyan <shc_work@mail.ru>
Tested-by: Alexander Shiyan <shc_work@mail.ru>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/nand/nand_base.c
drivers/mtd/nand/nand_ids.c
include/linux/mtd/nand.h