]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
dma: pl330: rip out broken, redundant ID probing
authorWill Deacon <will.deacon@arm.com>
Mon, 10 Jun 2013 18:34:37 +0000 (19:34 +0100)
committerVinod Koul <vinod.koul@intel.com>
Fri, 5 Jul 2013 06:10:41 +0000 (11:40 +0530)
commit09677176610e7c3ed8ddb302fd24bbb59bdbf205
treeb9f7b750216aa8e28748f517a47221d7f2849045
parent9479e17c9bb455c01b369d294e01de8fa9b0a8d3
dma: pl330: rip out broken, redundant ID probing

The PL330 driver probes the peripheral and primecell IDs of the device to
make sure that it is indeed an AMBA PL330. However, it does this by
making byte accesses to a device mapping of the word-aligned ID
registers, which is either UNPREDICTABLE or generates an alignment fault
(depending on the presence of the virtualisation extensions).

Rather than fix this code, we can actually rip most of it out and let
the AMBA bus driver correctly do the probing for us.

Cc: Jassi Brar <jaswinder.singh@linaro.org>
Cc: Vinod Koul <vinod.koul@intel.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Acked-by: Grant Likely <grant.likely@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/pl330.c