]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
rds: Integer overflow in RDS cmsg handling
authorDan Rosenberg <drosenberg@vsecurity.com>
Wed, 17 Nov 2010 06:37:16 +0000 (06:37 +0000)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 9 Dec 2010 21:27:12 +0000 (13:27 -0800)
commit0dd472b3a508ae8ec0b7ff3396e1a17434b78a75
tree551d61da986653aa737dbb869967c59c93f58be3
parent667b9703cf420799a25d816fdfd376a00e7ca0ae
rds: Integer overflow in RDS cmsg handling

commit 218854af84038d828a32f061858b1902ed2beec6 upstream.

In rds_cmsg_rdma_args(), the user-provided args->nr_local value is
restricted to less than UINT_MAX.  This seems to need a tighter upper
bound, since the calculation of total iov_size can overflow, resulting
in a small sock_kmalloc() allocation.  This would probably just result
in walking off the heap and crashing when calling rds_rdma_pages() with
a high count value.  If it somehow doesn't crash here, then memory
corruption could occur soon after.

Signed-off-by: Dan Rosenberg <drosenberg@vsecurity.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
net/rds/rdma.c