]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ALSA: usb-audio: Fix regression by disconnection-race-fix patch
authorTakashi Iwai <tiwai@suse.de>
Tue, 22 Jan 2013 16:43:40 +0000 (17:43 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Jan 2013 04:47:44 +0000 (20:47 -0800)
commit115b96e58609cff057d22d0e6118dae093763461
tree876a3a5e38947d02b75bca6509204a3f8f1f3312
parentb7cd50fb1dd6527706415bb61461d6f283a23dd4
ALSA: usb-audio: Fix regression by disconnection-race-fix patch

[NOTE: the regression below is found only in 3.2-3.4 stable trees, so
       there is no upstream commit corresponding to this patch]

The recent fix for the race at disconnection of usb-audio devices
(upstream commit 978520b7) triggers Oops when a device is unplugged
while playing on 3.2 and 3.4 kernels.  The culprit is that the
shutdown flag check was wrongly added around the urb deactivation code
snippet.  The urb deactivation code has to be performed even after the
device disconnected.  Otherwise it remains undead and pokes the wild
access in the end.

The regression fix is simply reverting the shutdown flag check in that
code.

Reported-and-tested-by: Chris J Arges <christopherarges@gmail.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/usb/endpoint.c