]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: bulk free SKBs that were delay free'ed due to IRQ context
authorJesper Dangaard Brouer <brouer@redhat.com>
Mon, 8 Feb 2016 12:15:04 +0000 (13:15 +0100)
committerDavid S. Miller <davem@davemloft.net>
Thu, 11 Feb 2016 16:59:09 +0000 (11:59 -0500)
commit15fad714be86eab13e7568fecaf475b2a9730d3e
tree08fa26b84fab14cb2a58b3a01599ffd513d28ba9
parent795bb1c00dd338aa0d12f9a7f1f4776fb3160416
net: bulk free SKBs that were delay free'ed due to IRQ context

The network stack defers SKBs free, in-case free happens in IRQ or
when IRQs are disabled. This happens in __dev_kfree_skb_irq() that
writes SKBs that were free'ed during IRQ to the softirq completion
queue (softnet_data.completion_queue).

These SKBs are naturally delayed, and cleaned up during NET_TX_SOFTIRQ
in function net_tx_action().  Take advantage of this a use the skb
defer and flush API, as we are already in softirq context.

For modern drivers this rarely happens. Although most drivers do call
dev_kfree_skb_any(), which detects the situation and calls
__dev_kfree_skb_irq() when needed.  This due to netpoll can call from
IRQ context.

Signed-off-by: Alexander Duyck <alexander.h.duyck@redhat.com>
Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
include/linux/skbuff.h
net/core/dev.c
net/core/skbuff.c