]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
thinkpad-acpi: lock down video output state access
authorHenrique de Moraes Holschuh <hmh@hmh.eng.br>
Fri, 26 Feb 2010 01:22:22 +0000 (22:22 -0300)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 26 Apr 2010 14:41:22 +0000 (07:41 -0700)
commit1b0d63f15fb79d0cb840f8b701f343548b5640e8
tree13544b47f91370a4d7be8d96a4801bcd26d11071
parenta772b90083481bd87458f48641dd7ba9e2401393
thinkpad-acpi: lock down video output state access

commit b525c06cdbd8a3963f0173ccd23f9147d4c384b5 upstream.

Given the right combination of ThinkPad and X.org, just reading the
video output control state is enough to hard-crash X.org.

Until the day I somehow find out a model or BIOS cut date to not
provide this feature to ThinkPads that can do video switching through
X RandR, change permissions so that only processes with CAP_SYS_ADMIN
can access any sort of video output control state.

This bug could be considered a local DoS I suppose, as it allows any
non-privledged local user to cause some versions of X.org to
hard-crash some ThinkPads.

Reported-by: Jidanni <jidanni@jidanni.org>
Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Documentation/laptops/thinkpad-acpi.txt
drivers/platform/x86/Kconfig
drivers/platform/x86/thinkpad_acpi.c