]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86, efi: Fix display detection in EFI boot stub
authorDavid Woodhouse <David.Woodhouse@intel.com>
Mon, 7 Jan 2013 21:52:16 +0000 (21:52 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 Feb 2013 00:27:06 +0000 (18:27 -0600)
commit23c70dc831ea93fa73b29167cd7ed94147b61386
tree60dd72486ec4a7efc61346b81ef8b84e92751e55
parent98e1ea492c1cf36ea3b391d9b5161681ee4ea18a
x86, efi: Fix display detection in EFI boot stub

commit 70a479cbe80296d3113e65cc2f713a5101061daf upstream.

When booting under OVMF we have precisely one GOP device, and it
implements the ConOut protocol.

We break out of the loop when we look at it... and then promptly abort
because 'first_gop' never gets set. We should set first_gop *before*
breaking out of the loop. Yes, it doesn't really mean "first" any more,
but that doesn't matter. It's only a flag to indicate that a suitable
GOP was found.

In fact, we'd do just as well to initialise 'width' to zero in this
function, then just check *that* instead of first_gop. But I'll do the
minimal fix for now (and for stable@).

Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Link: http://lkml.kernel.org/r/1358513837.2397.247.camel@shinybook.infradead.org
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/boot/compressed/eboot.c