]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86: Increase MIN_GAP to include randomized stack
authorMichal Hocko <mhocko@suse.cz>
Wed, 7 Oct 2009 21:38:24 +0000 (17:38 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 12 Oct 2009 18:33:15 +0000 (11:33 -0700)
commit2578cf95969936c372db29ee2bbc21c9b6a299aa
treeb4457e472665768c769b8447da3700b5fd52a855
parentda40cf167d517e0f2cdd79a0d0590482a8532585
x86: Increase MIN_GAP to include randomized stack

[ trivial backport to 2.6.27: Chuck Ebbert <cebbert@redhat.com> ]

commit 80938332d8cf652f6b16e0788cf0ca136befe0b5 upstream.

Currently we are not including randomized stack size when calculating
mmap_base address in arch_pick_mmap_layout for topdown case. This might
cause that mmap_base starts in the stack reserved area because stack is
randomized by 1GB for 64b (8MB for 32b) and the minimum gap is 128MB.

If the stack really grows down to mmap_base then we can get silent mmap
region overwrite by the stack values.

Let's include maximum stack randomization size into MIN_GAP which is
used as the low bound for the gap in mmap.

Signed-off-by: Michal Hocko <mhocko@suse.cz>
LKML-Reference: <1252400515-6866-1-git-send-email-mhocko@suse.cz>
Acked-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Cc: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/mm/mmap.c
include/asm-x86/elf.h