]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
RAID5: check_reshape() shouldn't call mddev_suspend
authorShaohua Li <shli@fb.com>
Thu, 25 Feb 2016 01:38:28 +0000 (17:38 -0800)
committerShaohua Li <shli@fb.com>
Fri, 26 Feb 2016 17:44:11 +0000 (09:44 -0800)
commit27a353c026a879a1001e5eac4bda75b16262c44a
tree7d4499f914d8199b263b8cbcbb4af7af0104e411
parente7597e69dec59b65c5525db1626b9d34afdfa678
RAID5: check_reshape() shouldn't call mddev_suspend

check_reshape() is called from raid5d thread. raid5d thread shouldn't
call mddev_suspend(), because mddev_suspend() waits for all IO finish
but IO is handled in raid5d thread, we could easily deadlock here.

This issue is introduced by
738a273 ("md/raid5: fix allocation of 'scribble' array.")

Cc: stable@vger.kernel.org (v4.1+)
Reported-and-tested-by: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Reviewed-by: NeilBrown <neilb@suse.com>
Signed-off-by: Shaohua Li <shli@fb.com>
drivers/md/raid5.c
drivers/md/raid5.h