]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
TOMOYO: Fix race on updating profile's comment line.
authorTetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Sat, 2 Apr 2011 15:09:26 +0000 (00:09 +0900)
committerJames Morris <jmorris@namei.org>
Mon, 18 Apr 2011 23:37:06 +0000 (09:37 +1000)
commit2a086e5d3a23570735f75b784d29b93068070833
tree43949632ba2e1c8ed4a8169d64c406d66ce36f23
parenta3232d2fa2e3cbab3e76d91cdae5890fee8a4034
TOMOYO: Fix race on updating profile's comment line.

In tomoyo_write_profile() since 2.6.34, a lock was by error missing when
replacing profile's comment line. If multiple threads attempted

  echo '0-COMMENT=comment' > /sys/kernel/security/tomoyo/profile

in parallel, garbage collector will fail to kfree() the old value.
Protect the replacement using a lock. Also, keep the old value rather than
replace with empty string when out of memory error has occurred.

Signed-off-by: Xiaochen Wang <wangxiaochen0@gmail.com>
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Signed-off-by: James Morris <jmorris@namei.org>
security/tomoyo/common.c