]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
xfrm_user: propagate sec ctx allocation errors
authorMathias Krause <minipli@googlemail.com>
Thu, 8 Sep 2016 16:09:57 +0000 (18:09 +0200)
committerSteffen Klassert <steffen.klassert@secunet.com>
Fri, 9 Sep 2016 07:02:08 +0000 (09:02 +0200)
commit2f30ea5090cbc57ea573cdc66421264b3de3fb0a
tree7602a1be11bed9830f738558048fd87b3aca0e4f
parent2c2c8e33e4aa6e46f19ef7bba8e559759a74a4db
xfrm_user: propagate sec ctx allocation errors

When we fail to attach the security context in xfrm_state_construct()
we'll return 0 as error value which, in turn, will wrongly claim success
to userland when, in fact, we won't be adding / updating the XFRM state.

This is a regression introduced by commit fd21150a0fe1 ("[XFRM] netlink:
Inline attach_encap_tmpl(), attach_sec_ctx(), and attach_one_addr()").

Fix it by propagating the error returned by security_xfrm_state_alloc()
in this case.

Fixes: fd21150a0fe1 ("[XFRM] netlink: Inline attach_encap_tmpl()...")
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Cc: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_user.c