]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
EDAC: Use edac_debugfs_remove_recursive()
authorTan Xiaojun <tanxiaojun@huawei.com>
Wed, 14 Oct 2015 01:49:24 +0000 (09:49 +0800)
committerBorislav Petkov <bp@suse.de>
Wed, 14 Oct 2015 16:50:32 +0000 (18:50 +0200)
commit30f84a891bf6dc7ffb9c0d0f3361ca6375633ac1
treeb930629ab7765f7657de650c43eeb59780812364
parent90b3b37383fd083481655d5529686ca4eda4da2b
EDAC: Use edac_debugfs_remove_recursive()

debugfs_remove() is used to remove a file or a directory from the
debugfs filesystem, but mci->debugfs might not empty.

This can be triggered by the following sequence:

1) Enable CONFIG_EDAC_DEBUG
2) insmod an EDAC module (like i3000_edac or similar)
3) rmmod this module
4) we can see files remaining under <debugfs_mountpoint>/edac/ like
   "fake_inject", for example.

Removing edac_core then, causes a NULL pointer dereference.

Reported-by: Yun Wu (Abel) <wuyun.wu@huawei.com>
Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
Cc: Doug Thompson <dougthompson@xmission.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-edac <linux-edac@vger.kernel.org>
Link: http://lkml.kernel.org/r/1444787364-104353-1-git-send-email-tanxiaojun@huawei.com
Signed-off-by: Borislav Petkov <bp@suse.de>
drivers/edac/debugfs.c
drivers/edac/edac_mc_sysfs.c