]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
thermal: make THERMAL_HWMON implementation fully internal
authorJean Delvare <khali@linux-fr.org>
Thu, 28 Jul 2011 20:48:42 +0000 (13:48 -0700)
committerLen Brown <len.brown@intel.com>
Tue, 2 Aug 2011 18:51:57 +0000 (14:51 -0400)
commit31f5396ad3bde23c8416e8d23ba425e27f413314
tree923ec07b9afff6cf952cbc2bd5f26bf490793c6f
parent0d97d7a494d43be77f57e688369be0aae33d1ade
thermal: make THERMAL_HWMON implementation fully internal

THERMAL_HWMON is implemented inside the thermal_sys driver and has no
effect on drivers implementing thermal zones, so they shouldn't see
anything related to it in <linux/thermal.h>.  Making the THERMAL_HWMON
implementation fully internal has two advantages beyond the cleaner
design:

* This avoids rebuilding all thermal drivers if the THERMAL_HWMON
  implementation changes, or if CONFIG_THERMAL_HWMON gets enabled or
  disabled.

* This avoids breaking the thermal kABI in these cases too, which should
  make distributions happy.

The only drawback I can see is slightly higher memory fragmentation, as
the number of kzalloc() calls will increase by one per thermal zone.  But
I doubt it will be a problem in practice, as I've never seen a system with
more than two thermal zones.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Rene Herman <rene.herman@gmail.com>
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/thermal/thermal_sys.c
include/linux/thermal.h