]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
THERMAL_HWMON is implemented inside the thermal_sys driver and has no
authorJean Delvare <khali@linux-fr.org>
Tue, 26 Jul 2011 10:14:36 +0000 (20:14 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Tue, 2 Aug 2011 05:14:16 +0000 (15:14 +1000)
commit48e4c27ca56aa565de0ab80ab32662c929f2c66c
tree10513c874d918002ce38d1e33a712948e652b7bb
parentf0414ef96aa445c6a09185131fa15017e47de5b1
THERMAL_HWMON is implemented inside the thermal_sys driver and has no
effect on drivers implementing thermal zones, so they shouldn't see
anything related to it in <linux/thermal.h>.  Making the THERMAL_HWMON
implementation fully internal has two advantages beyond the cleaner
design:

* This avoids rebuilding all thermal drivers if the THERMAL_HWMON
  implementation changes, or if CONFIG_THERMAL_HWMON gets enabled or
  disabled.

* This avoids breaking the thermal kABI in these cases too, which should
  make distributions happy.

The only drawback I can see is slightly higher memory fragmentation, as
the number of kzalloc() calls will increase by one per thermal zone.  But
I doubt it will be a problem in practice, as I've never seen a system with
more than two thermal zones.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Rene Herman <rene.herman@gmail.com>
Cc: Len Brown <len.brown@intel.com>
Acked-by: Guenter Roeck <guenter.roeck@ericsson.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
drivers/thermal/thermal_sys.c
include/linux/thermal.h