]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
check_unsafe_exec: s/lock_task_sighand/rcu_read_lock/
authorOleg Nesterov <oleg@redhat.com>
Thu, 23 Apr 2009 23:02:45 +0000 (01:02 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 8 May 2009 22:45:09 +0000 (15:45 -0700)
commit4cc341cacb9288d4678e1b899af0a5ac66dbe2f2
tree01010705d706af49b8fd1e4662a30348f022a11e
parent7fd619d45f54fc09dc7bb908edae518d8aa05516
check_unsafe_exec: s/lock_task_sighand/rcu_read_lock/

commit 437f7fdb607f32b737e4da9f14bebcfdac2c90c3 upstream.

write_lock(&current->fs->lock) guarantees we can't wrongly miss
LSM_UNSAFE_SHARE, this is what we care about. Use rcu_read_lock()
instead of ->siglock to iterate over the sub-threads. We must see
all CLONE_THREAD|CLONE_FS threads which didn't pass exit_fs(), it
takes fs->lock too.

With or without this patch we can miss the freshly cloned thread
and set LSM_UNSAFE_SHARE, we don't care.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Roland McGrath <roland@redhat.com>
[ Fixed lock/unlock typo  - Hugh ]
Acked-by: Hugh Dickins <hugh@veritas.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/exec.c