]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
af_unix: limit unix_tot_inflight
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 24 Nov 2010 17:15:27 +0000 (09:15 -0800)
committerAK <andi@firstfloor.org>
Sun, 6 Feb 2011 19:03:35 +0000 (11:03 -0800)
commit4d6d4fae2b988f48b94d93bc398fdf353463ec40
tree8e88aff2d7d66c44421678b44e37ce75d7147320
parentb628317b1d1a58bc5722c982fce2729120438734
af_unix: limit unix_tot_inflight

[ Upstream commit 9915672d41273f5b77f1b3c29b391ffb7732b84b ]

Vegard Nossum found a unix socket OOM was possible, posting an exploit
program.

My analysis is we can eat all LOWMEM memory before unix_gc() being
called from unix_release_sock(). Moreover, the thread blocked in
unix_gc() can consume huge amount of time to perform cleanup because of
huge working set.

One way to handle this is to have a sensible limit on unix_tot_inflight,
tested from wait_for_unix_gc() and to force a call to unix_gc() if this
limit is hit.

This solves the OOM and also reduce overall latencies, and should not
slowdown normal workloads.

Reported-by: Vegard Nossum <vegard.nossum@gmail.com>
Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
net/unix/garbage.c