]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
udf: avoid uninitialized variable use
authorArnd Bergmann <arnd@arndb.de>
Fri, 1 Jan 2016 14:21:54 +0000 (15:21 +0100)
committerJan Kara <jack@suse.cz>
Mon, 4 Jan 2016 09:53:29 +0000 (10:53 +0100)
commit4f1b1519f7bec44ded3c2c4d46a2594c01446dc8
treeac4d99781d728a027d8f629354a81e4ae0955901
parent6c37157874aa2b153b722868bd984002fbcff6bb
udf: avoid uninitialized variable use

A new warning has come up from a recent cleanup:

fs/udf/inode.c: In function 'udf_setup_indirect_aext':
fs/udf/inode.c:1927:28: warning: 'adsize' may be used uninitialized in this function [-Wmaybe-uninitialized]

If the alloc_type is neither ICBTAG_FLAG_AD_SHORT nor
ICBTAG_FLAG_AD_LONG, the value of adsize is undefined. Currently,
callers of these functions make sure alloc_type is one of the two valid
ones but for future proofing make sure we handle the case of invalid
alloc type as well.  This changes the code to return -EIOin that case.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: fcea62babc81 ("udf: Factor out code for creating indirect extent")
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/inode.c