]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
drm: Release resources with a safer function
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 2 Oct 2016 06:01:22 +0000 (08:01 +0200)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Wed, 5 Oct 2016 13:16:54 +0000 (15:16 +0200)
commit587680c1c52d73bc7d5dbba2dcfadacb7a3f6b0e
tree0706cf37def55b3a4a37b2b2e51f5f7899101a05
parent0546d685f07cc4fc5748fd36e57d167877c2842d
drm: Release resources with a safer function

We should use 'ida_simple_remove()' instead of 'ida_remove()' when freeing
resources allocated with 'ida_simple_get()'.

This as been spotted with the following coccinelle script which tries to
detect missing 'ida_simple_remove()' call in error handling paths.

///////////////
@@
expression x;
identifier l;
@@

*   x = ida_simple_get(...);
    ...
    if (...) {
    ...
    }
    ...
    if (...) {
       ...
       goto l;
    }
    ...
*   l: ... when != ida_simple_remove(...);

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/1475388082-12656-1-git-send-email-christophe.jaillet@wanadoo.fr
drivers/gpu/drm/drm_connector.c