]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
p54pci: rx frame length check
authorChristian Lamparter <chunkeey@googlemail.com>
Sun, 17 Jan 2010 23:07:38 +0000 (00:07 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 May 2010 21:57:11 +0000 (14:57 -0700)
commit63ab8b7b6c1b21af040a2c8321092bce11bb561f
treee55ad7f09b2a870e3e0d2305d4ec8cb573deec43
parent0c468b435fa14744fc25ad999d357afcba710954
p54pci: rx frame length check

commit f5300e04df78feae8107c1846dd3a9e27c071b2f upstream.

A long time ago, a user reported several crashes due to
data corruptions which are likely the result of a
not-100%-supported, or faulty? PCI bridge.
( http://patchwork.kernel.org/patch/53004/ )

This patch fixes entry #1.
"1.  p54p_check_rx_ring - skb_over_panic: Under a ping flood
or just left running for a bit would panic with a skb_over_panic."
As described in the mail: The invalid frame length causes
skb_put to bailout and trigger a crash.

Note:
Simply dropping the frame is problematic, because if its content
contains a tx feedback we would lose some portion of the device
memory space.... And the driver/mac80211 should handle all other
invalid data.

Reported-by: Quintin Pitts <geek4linux@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/net/wireless/p54/p54pci.c