]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
perf: Resurrect flat callchains
authorFrederic Weisbecker <fweisbec@gmail.com>
Thu, 8 Jul 2010 04:06:17 +0000 (06:06 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 2 Aug 2010 17:20:51 +0000 (10:20 -0700)
commit6485aae3ca859679d0742badd14b20f2cc922d23
tree45a3e005a1175c71fe1c4d08a96973277faa7789
parent04cdd492dce4e063d9ddd8675c4ebdeac5e5dc13
perf: Resurrect flat callchains

commit 97aa1052739c6a06cb6b0467dbf410613d20bc97 upstream.

Initialize the callchain radix tree root correctly.

When we walk through the parents, we must stop after the root, but
since it wasn't well initialized, its parent pointer was random.

Also the number of hits was random because uninitialized, hence it
was part of the callchain while the root doesn't contain anything.

This fixes segfaults and percentages followed by empty callchains
while running:

perf report -g flat

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Paul Mackerras <paulus@samba.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
tools/perf/util/callchain.h