]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
skip sense logging for some ATA PASS-THROUGH cdbs
authorDouglas Gilbert <dgilbert@interlog.com>
Sun, 3 Jan 2010 18:51:15 +0000 (13:51 -0500)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 12 May 2010 21:57:13 +0000 (14:57 -0700)
commit6f12efee9e86b52193aa2e7e14ad013fc3153a8a
treee5e7d16bc0e13054b982089a7ff452af34567107
parent523273f08eb995890ab4c3012cb95fd07686de1c
skip sense logging for some ATA PASS-THROUGH cdbs

commit e7efe5932b1d3916c79326a4221693ea90a900e2 upstream.

Further to the lsml thread titled:
"does scsi_io_completion need to dump sense data for ata pass through (ck_cond =
1) ?"

This is a patch to skip logging when the sense data is
associated with a SENSE_KEY of "RECOVERED_ERROR" and the
additional sense code is "ATA PASS-THROUGH INFORMATION
AVAILABLE". This only occurs with the SAT ATA PASS-THROUGH
commands when CK_COND=1 (in the cdb). It indicates that
the sense data contains ATA registers.

Smartmontools uses such commands on ATA disks connected via
SAT. Periodic checks such as those done by smartd cause
nuisance entries into logs that are:
    - neither errors nor warnings
    - pointless unless the cdb that caused them are also logged

Signed-off-by: Douglas Gilbert <dgilbert@interlog.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/scsi/scsi_lib.c