]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
random: Add comment to random_initialize()
authorTony Luck <tony.luck@intel.com>
Mon, 23 Jul 2012 16:47:57 +0000 (09:47 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Aug 2012 15:10:29 +0000 (08:10 -0700)
commit73e62ae900d632d1bee9ab96c22508f8947da91a
tree1cd49e85fd4217c94de3969a374d6ea539dd808d
parent26665db4f7fa71c56eeb9205e79927cfc21e70c4
random: Add comment to random_initialize()

commit cbc96b7594b5691d61eba2db8b2ea723645be9ca upstream.

Many platforms have per-machine instance data (serial numbers,
asset tags, etc.) squirreled away in areas that are accessed
during early system bringup. Mixing this data into the random
pools has a very high value in providing better random data,
so we should allow (and even encourage) architecture code to
call add_device_randomness() from the setup_arch() paths.

However, this limits our options for internal structure of
the random driver since random_initialize() is not called
until long after setup_arch().

Add a big fat comment to rand_initialize() spelling out
this requirement.

Suggested-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/random.c