]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
sched: Make select_fallback_rq() cpuset friendly
authorOleg Nesterov <oleg@redhat.com>
Mon, 15 Mar 2010 09:10:27 +0000 (10:10 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 20 Sep 2010 20:18:08 +0000 (13:18 -0700)
commit81695bf0ee1a6b3f2a8f183273d945decc1d3f18
tree23ae28a2592b20f7068d48a8b589acf39670be98
parent1ccc5a299bd54b1c0f0bac6316c45b6ce31b9ac1
sched: Make select_fallback_rq() cpuset friendly

commit 9084bb8246ea935b98320554229e2f371f7f52fa upstream

Introduce cpuset_cpus_allowed_fallback() helper to fix the cpuset problems
with select_fallback_rq(). It can be called from any context and can't use
any cpuset locks including task_lock(). It is called when the task doesn't
have online cpus in ->cpus_allowed but ttwu/etc must be able to find a
suitable cpu.

I am not proud of this patch. Everything which needs such a fat comment
can't be good even if correct. But I'd prefer to not change the locking
rules in the code I hardly understand, and in any case I believe this
simple change make the code much more correct compared to deadlocks we
currently have.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <20100315091027.GA9155@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Mike Galbraith <efault@gmx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
include/linux/cpuset.h
kernel/cpuset.c
kernel/sched.c