]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
virtio_console: fix a crash in config_work_handler
authorG. Campana <gcampana@quarkslab.com>
Thu, 19 Jan 2017 21:37:46 +0000 (23:37 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Thu, 19 Jan 2017 21:46:31 +0000 (23:46 +0200)
commit8379cadf71c3ee8173a1c6fc1ea7762a9638c047
tree7c2fab5b7c5ea52202919e83e0bb0e4801193c21
parent532e15af105a0b86211f515bd5fec1f4cdd9f27b
virtio_console: fix a crash in config_work_handler

Using control_work instead of config_work as the 3rd argument to
container_of results in an invalid portdev pointer. Indeed, the work
structure is initialized as below:

    INIT_WORK(&portdev->config_work, &config_work_handler);

It leads to a crash when portdev->vdev is dereferenced later. This
bug
is triggered when the guest uses a virtio-console without multiport
feature and receives a config_changed virtio interrupt.

Signed-off-by: G. Campana <gcampana@quarkslab.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
drivers/char/virtio_console.c