]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
cifs: fix possible memory corruption in CIFSFindNext
authorJeff Layton <jlayton@redhat.com>
Tue, 23 Aug 2011 11:21:28 +0000 (07:21 -0400)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 3 Oct 2011 18:40:35 +0000 (11:40 -0700)
commit862bee39ef540bd3a7772b899b4fa7f3036abf0d
tree2bac0acdffbb15965ef6f291ae7a78c684b768b5
parente9bfcbffb7b26065a2b467e29bb6c7ec83d17646
cifs: fix possible memory corruption in CIFSFindNext

commit 9438fabb73eb48055b58b89fc51e0bc4db22fabd upstream.

The name_len variable in CIFSFindNext is a signed int that gets set to
the resume_name_len in the cifs_search_info. The resume_name_len however
is unsigned and for some infolevels is populated directly from a 32 bit
value sent by the server.

If the server sends a very large value for this, then that value could
look negative when converted to a signed int. That would make that
value pass the PATH_MAX check later in CIFSFindNext. The name_len would
then be used as a length value for a memcpy. It would then be treated
as unsigned again, and the memcpy scribbles over a ton of memory.

Fix this by making the name_len an unsigned value in CIFSFindNext.

Reported-by: Darren Lavender <dcl@hppine99.gbr.hp.com>
Signed-off-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/cifs/cifssmb.c