]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
dio-inline-the-complete-submission-path-v2-checkpatch-fixes
authorAndrew Morton <akpm@linux-foundation.org>
Wed, 5 Oct 2011 00:44:05 +0000 (11:44 +1100)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 13 Oct 2011 06:50:04 +0000 (17:50 +1100)
commit97147b30a0be53aaf9bb6614e7c0f8a899fca34c
treecb4e26157aba25f3086096d107f316be28d6c8ff
parent24638b5f516f74143e5cc0622143beef6f527192
dio-inline-the-complete-submission-path-v2-checkpatch-fixes

WARNING: line over 80 characters
#46: FILE: fs/direct-io.c:248:
+static inline struct page *dio_get_page(struct dio *dio, struct dio_submit *sdio)

ERROR: inline keyword should sit between storage class and type
#55: FILE: fs/direct-io.c:379:
+static void inline

ERROR: trailing whitespace
#91: FILE: fs/direct-io.c:634:
+static inline int dio_new_bio(struct dio *dio, struct dio_submit *sdio, $

ERROR: code indent should use tabs where possible
#111: FILE: fs/direct-io.c:693:
+^I  ^I^I    ^I    struct buffer_head *map_bh)$

WARNING: please, no space before tabs
#111: FILE: fs/direct-io.c:693:
+^I  ^I^I    ^I    struct buffer_head *map_bh)$

WARNING: line over 80 characters
#129: FILE: fs/direct-io.c:845:
+static inline void dio_zero_block(struct dio *dio, struct dio_submit *sdio, int end,

ERROR: trailing whitespace
#146: FILE: fs/direct-io.c:1216:
+ * $

ERROR: trailing whitespace
#149: FILE: fs/direct-io.c:1219:
+ * individual fields and will generate much worse code. $

total: 5 errors, 3 warnings, 109 lines checked

NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or
      scripts/cleanfile

./patches/dio-inline-the-complete-submission-path-v2.patch has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

Please run checkpatch prior to sending patches

Cc: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/direct-io.c