]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ipc ns: fix memory leak (idr)
authorSerge E. Hallyn <serue@us.ibm.com>
Wed, 16 Dec 2009 00:47:27 +0000 (16:47 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 28 Jan 2010 23:02:25 +0000 (15:02 -0800)
commita0dffef3213a314d3a53e4fffe7d325edbe1d05c
tree5a46d7d1753613d43414253d0962239ea5295b80
parenta5981dfb82297858395742530509c7f80a41e3bd
ipc ns: fix memory leak (idr)

commit 7d6feeb287c61aafa88f06345387b1188edf4b86 upstream.

We have apparently had a memory leak since
7ca7e564e049d8b350ec9d958ff25eaa24226352 "ipc: store ipcs into IDRs" in
2007.  The idr of which 3 exist for each ipc namespace is never freed.

This patch simply frees them when the ipcns is freed.  I don't believe any
idr_remove() are done from rcu (and could therefore be delayed until after
this idr_destroy()), so the patch should be safe.  Some quick testing
showed no harm, and the memory leak fixed.

Caught by kmemleak.

Signed-off-by: Serge E. Hallyn <serue@us.ibm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Acked-by: Nick Piggin <npiggin@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
ipc/msg.c
ipc/sem.c
ipc/shm.c