]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
hwmon: (asus_atk0110) fix uninitialized data access
authorArnd Bergmann <arnd@arndb.de>
Thu, 23 Mar 2017 15:03:11 +0000 (16:03 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Thu, 23 Mar 2017 19:01:57 +0000 (12:01 -0700)
commita2125d02443e9a4e68bcfd9f8004fa23239e8329
tree7793a248f25e75ad5795439013c35cb64622d0f4
parenta5023a99393dab276069cd60dad3e61d57720fda
hwmon: (asus_atk0110) fix uninitialized data access

The latest gcc-7 snapshot adds a warning to point out that when
atk_read_value_old or atk_read_value_new fails, we copy
uninitialized data into sensor->cached_value:

drivers/hwmon/asus_atk0110.c: In function 'atk_input_show':
drivers/hwmon/asus_atk0110.c:651:26: error: 'value' may be used uninitialized in this function [-Werror=maybe-uninitialized]

Adding an error check avoids this. All versions of the driver
are affected.

Fixes: 2c03d07ad54d ("hwmon: Add Asus ATK0110 support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Luca Tettamanti <kronos.it@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/asus_atk0110.c