]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
RDS/IB: rds_ib_cm_handle_connect() forgot to unlock c_cm_lock
authorZach Brown <zach.brown@oracle.com>
Mon, 24 May 2010 20:14:59 +0000 (13:14 -0700)
committerAndy Grover <andy.grover@oracle.com>
Thu, 9 Sep 2010 01:15:15 +0000 (18:15 -0700)
commita46ca94e7fb2c93a59e08b42fd77d8c478fda5fc
tree2c7e4be2d85d55c0fc69d60c18504d8eec4acfe2
parent1cc2228c599f173d77000a250bf0541294e1a7be
RDS/IB: rds_ib_cm_handle_connect() forgot to unlock c_cm_lock

rds_ib_cm_handle_connect() could return without unlocking the c_conn_lock if
rds_setup_qp() failed.  Rather than adding another imbalanced mutex_unlock() to
this error path we only unlock the mutex once as we exit the function, reducing
the likelyhood of making this same mistake in the future.  We remove the
previous mulitple return sites, leaving one unambigious return path.

Signed-off-by: Zach Brown <zach.brown@oracle.com>
net/rds/ib_cm.c