]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
IB/uverbs: Fix checking of userspace object ownership
authorRoland Dreier <rolandd@cisco.com>
Sun, 28 Oct 2007 17:14:32 +0000 (10:14 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 16 Nov 2007 17:30:20 +0000 (09:30 -0800)
commita8ebc7bceb104fa5e1ef1ce116d3fd85f2081af2
tree28a9b657e0943872e4e22ef4d9a2198d38cd4713
parent813476de234d567b55404d45a568abb95d1e05c6
IB/uverbs: Fix checking of userspace object ownership

Upstream as cbfb50e6e2e9c580848c0f51d37c24cdfb1cb704

Commit 9ead190b ("IB/uverbs: Don't serialize with ib_uverbs_idr_mutex")
rewrote how userspace objects are looked up in the uverbs module's
idrs, and introduced a severe bug in the process: there is no checking
that an operation is being performed by the right process any more.
Fix this by adding the missing check of uobj->context in __idr_get_uobj().

Apparently everyone is being very careful to only touch their own
objects, because this bug was introduced in June 2006 in 2.6.18, and
has gone undetected until now.

Signed-off-by: Roland Dreier <rolandd@cisco.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/infiniband/core/uverbs_cmd.c