]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
staging: comedi: fix clean-up of comedi_class in comedi_init()
authorIan Abbott <abbotti@mev.co.uk>
Fri, 16 Jun 2017 18:35:34 +0000 (19:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Jun 2017 16:37:07 +0000 (00:37 +0800)
commita9332e9ad09c2644c99058fcf6ae2f355e93ce74
treedd7f1f3f840bb8d63d615c4fd0f952c2d1855cb8
parentf0836fd2a683bafbf738672e429221e4e9a3d7a6
staging: comedi: fix clean-up of comedi_class in comedi_init()

There is a clean-up bug in the core comedi module initialization
functions, `comedi_init()`.  If the `comedi_num_legacy_minors` module
parameter is non-zero (and valid), it creates that many "legacy" devices
and registers them in SysFS.  A failure causes the function to clean up
and return an error.  Unfortunately, it fails to destroy the "comedi"
class that was created earlier.  Fix it by adding a call to
`class_destroy(comedi_class)` at the appropriate place in the clean-up
sequence.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Cc: <stable@vger.kernel.org> # 3.9+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/comedi_fops.c