]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
pid-namespace: limit value of ns_last_pid to (0, max_pid)
authorAndrew Vagin <avagin@openvz.org>
Thu, 13 Sep 2012 00:58:11 +0000 (10:58 +1000)
committerStephen Rothwell <sfr@canb.auug.org.au>
Thu, 13 Sep 2012 07:27:37 +0000 (17:27 +1000)
commitb07abc9a93c199ed322c0a34d8ee8459843f833b
tree20f08d5fa698d39c04bbce077a419a62da5c226b
parent857f8dba7dfb747ff57ab7d3d46abd37c4aec9c3
pid-namespace: limit value of ns_last_pid to (0, max_pid)

The kernel doesn't check the pid for negative values, so if you try to
write -2 to /proc/sys/kernel/ns_last_pid, you will get a kernel panic.

The crash happens because the next pid is -1, and alloc_pidmap() will try
to access to a nonexistent pidmap.

map = &pid_ns->pidmap[pid/BITS_PER_PAGE];

Signed-off-by: Andrew Vagin <avagin@openvz.org>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Cc: Pavel Emelyanov <xemul@parallels.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
kernel/pid_namespace.c