]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
hwmon: (ads7871) Fix ads7871_probe error paths
authorAxel Lin <axel.lin@gmail.com>
Wed, 25 Aug 2010 13:42:10 +0000 (15:42 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 20 Sep 2010 20:36:04 +0000 (13:36 -0700)
commitb3f69c04298fecbd5ca382679bac644433771dae
tree5d5a58506125df33a665d09ea49dab47181324fb
parent1506707a6c740db316e422239a53ae5df1727591
hwmon: (ads7871) Fix ads7871_probe error paths

commit c12c507d7185fe4e8ada7ed9832957576eefecf8 upstream.

1. remove 'status' variable
2. remove unneeded initialization of 'err' variable
3. return missing error code if sysfs_create_group fail.
4. fix the init sequence as:
   - check hardware existence
   - kzalloc for ads7871_data
   - sysfs_create_group
   - hwmon_device_register

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/hwmon/ads7871.c