]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
execve: improve interactivity with large arguments
authorRoland McGrath <roland@redhat.com>
Wed, 8 Sep 2010 02:36:28 +0000 (19:36 -0700)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 29 Oct 2010 04:44:17 +0000 (21:44 -0700)
commitbd720c923f7febe45934f4e87c4c755e45b13bdc
treee3ba8598d010a3bbc0c197bcb91e9615061e29d8
parent8816b5d01705e2c5c32bbf9e39e9aebad10b5dca
execve: improve interactivity with large arguments

commit 7993bc1f4663c0db67bb8f0d98e6678145b387cd upstream.

This adds a preemption point during the copying of the argument and
environment strings for execve, in copy_strings().  There is already
a preemption point in the count() loop, so this doesn't add any new
points in the abstract sense.

When the total argument+environment strings are very large, the time
spent copying them can be much more than a normal user time slice.
So this change improves the interactivity of the rest of the system
when one process is doing an execve with very large arguments.

Signed-off-by: Roland McGrath <roland@redhat.com>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Chuck Ebbert <cebbert@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/exec.c