]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
bnxt_en: Remove locking around txr->dev_state
authorFlorian Fainelli <f.fainelli@gmail.com>
Mon, 18 Jul 2016 20:02:47 +0000 (13:02 -0700)
committerDavid S. Miller <davem@davemloft.net>
Wed, 20 Jul 2016 02:22:38 +0000 (19:22 -0700)
commitcbce91cad4ee39070bf3c7873767194e4be88e16
tree9b02db867158fb2c3bff4a19d62a19efacd5fec0
parent7e0433b3956b6d110fb8ab7d607841603285a40d
bnxt_en: Remove locking around txr->dev_state

txr->dev_state was not consistently manipulated with the acquisition of
the per-queue lock, after further inspection the lock does not seem
necessary, either the value is read as BNXT_DEV_STATE_CLOSING or 0.

Reported-by: coverity (CID 1339583)
Fixes: c0c050c58d840 ("bnxt_en: New Broadcom ethernet driver.")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c