]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
ARM: 7477/1: vfp: Always save VFP state in vfp_pm_suspend on UP
authorColin Cross <ccross@android.com>
Fri, 20 Jul 2012 01:03:42 +0000 (02:03 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 9 Aug 2012 23:25:05 +0000 (00:25 +0100)
commitcdab6eed39be615703f582831765e14fb0452842
tree6343f638b4c32fb76b90dd7b29acef476e6d1ba5
parentfc257bc543a3b08545e2332574a12893f0e54c85
ARM: 7477/1: vfp: Always save VFP state in vfp_pm_suspend on UP

commit 24b35521b8ddf088531258f06f681bb7b227bf47 upstream.

vfp_pm_suspend should save the VFP state in suspend after
any lazy context switch.  If it only saves when the VFP is enabled,
the state can get lost when, on a UP system:
  Thread 1 uses the VFP
  Context switch occurs to thread 2, VFP is disabled but the
     VFP context is not saved
  Thread 2 initiates suspend
  vfp_pm_suspend is called with the VFP disabled, and the unsaved
     VFP context of Thread 1 in the registers

Modify vfp_pm_suspend to save the VFP context whenever
vfp_current_hw_state is not NULL.

Includes a fix from Ido Yariv <ido@wizery.com>, who pointed out that on
SMP systems, the state pointer can be pointing to a freed task struct if
a task exited on another cpu, fixed by using #ifndef CONFIG_SMP in the
new if clause.

Cc: Barry Song <bs14@csr.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Ido Yariv <ido@wizery.com>
Cc: Daniel Drake <dsd@laptop.org>
Cc: Will Deacon <will.deacon@arm.com>
Signed-off-by: Colin Cross <ccross@android.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
arch/arm/vfp/vfpmodule.c