]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
libata: retry FS IOs even if it has failed with AC_ERR_INVALID
authorTejun Heo <tj@kernel.org>
Thu, 14 Jan 2010 07:18:09 +0000 (16:18 +0900)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 26 May 2010 21:27:08 +0000 (14:27 -0700)
commitce58c0ab4bcf38482dfc095af0c4ed55a5a88698
treef5f53a38d3dff66820b407c74089d48f2d948021
parentbf3d0e3c484815ea68c671a4da71fd2e01cc1ac6
libata: retry FS IOs even if it has failed with AC_ERR_INVALID

commit 534ead709235b967b659947c55d9130873a432c4 upstream.

libata currently doesn't retry if a command fails with AC_ERR_INVALID
assuming that retrying won't get it any further even if retried.
However, a failure may be classified as invalid through hardware
glitch (incorrect reading of the error register or firmware bug) and
there isn't whole lot to gain by not retrying as actually invalid
commands will be failed immediately.  Also, commands serving FS IOs
are extremely unlikely to be invalid.  Retry FS IOs even if it's
marked invalid.

Transient and incorrect invalid failure was seen while debugging
firmware related issue on Samsung n130 on bko#14314.

  http://bugzilla.kernel.org/show_bug.cgi?id=14314

Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Johannes Stezenbach <js@sig21.net>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/ata/libata-eh.c