]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
[PATCH] SCTP: Always linearise packet on input
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 30 Oct 2006 07:48:51 +0000 (23:48 -0800)
committerChris Wright <chrisw@sous-sol.org>
Sat, 4 Nov 2006 01:33:48 +0000 (17:33 -0800)
commitcea23cd94f286008d382ccee265ca417c9ce9a58
treeb75c0edafcc2fe9c971236cd2182553ab0563ccd
parent5565a6be17231fdcbaa65e2ef41e4f67bf709a81
[PATCH] SCTP: Always linearise packet on input

I was looking at a RHEL5 bug report involving Xen and SCTP
(https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=212550).
It turns out that SCTP wasn't written to handle skb fragments at
all.  The absence of any calls to skb_may_pull is testament to
that.

It just so happens that Xen creates fragmented packets more often
than other scenarios (header & data split when going from domU to
dom0).  That's what caused this bug to show up.

Until someone has the time sits down and audits the entire net/sctp
directory, here is a conservative and safe solution that simply
linearises all packets on input.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
net/sctp/input.c