]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
powerpc/xmon: Don't signal we've entered until we're finished printing
authorMichael Ellerman <mpe@ellerman.id.au>
Mon, 23 Dec 2013 12:46:06 +0000 (23:46 +1100)
committerBenjamin Herrenschmidt <benh@kernel.crashing.org>
Tue, 11 Feb 2014 00:24:51 +0000 (11:24 +1100)
commitd2b496e5e1fa7a6796534e435440eb9d3ed184dd
tree8de313f2c772d2d62a8bdaeb3ed5c2aff0ea5253
parent1507589787529b0d8e2a9e66e0c6f113ecab5181
powerpc/xmon: Don't signal we've entered until we're finished printing

Currently we set our cpu's bit in cpus_in_xmon, and then we take the
output lock and print the exception information.

This can race with the master cpu entering the command loop and printing
the backtrace. The result is that the backtrace gets garbled with
another cpu's exception print out.

Fix it by delaying the set of cpus_in_xmon until we are finished
printing.

Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/xmon/xmon.c