]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
net: packet: fix information leak to userland
authorVasiliy Kulikov <segooon@gmail.com>
Wed, 10 Nov 2010 20:09:10 +0000 (12:09 -0800)
committerAK <andi@firstfloor.org>
Sun, 6 Feb 2011 19:03:40 +0000 (11:03 -0800)
commitd3c6045fee29a799083d3431da555053e3140eaf
tree69a7cfbcfb80de5c63d07722e6037450a8fc0081
parent64c80cfe40b35c06a7cbf2806fcc2c14460405ab
net: packet: fix information leak to userland

[ Upstream commit 67286640f638f5ad41a946b9a3dc75327950248f ]

packet_getname_spkt() doesn't initialize all members of sa_data field of
sockaddr struct if strlen(dev->name) < 13.  This structure is then copied
to userland.  It leads to leaking of contents of kernel stack memory.
We have to fully fill sa_data with strncpy() instead of strlcpy().

The same with packet_getname(): it doesn't initialize sll_pkttype field of
sockaddr_ll.  Set it to zero.

Signed-off-by: Vasiliy Kulikov <segooon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
net/packet/af_packet.c