]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
x86, msr/cpuid: Register enough minors for the MSR and CPUID drivers
authorH. Peter Anvin <hpa@zytor.com>
Tue, 15 Dec 2009 23:13:07 +0000 (15:13 -0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Mon, 25 Jan 2010 18:49:12 +0000 (10:49 -0800)
commitd547e913ca2e6ec29510cca3e72a3cc430e53b89
treed4bac397cedc09c563ab45a199dc853835f0175b
parenta2febcd43d859a48672ad922990bd27e5628271f
x86, msr/cpuid: Register enough minors for the MSR and CPUID drivers

commit 0b962d473af32ec334df271b54ff4973cb2b4c73 upstream.

register_chrdev() hardcodes registering 256 minors, presumably to
avoid breaking old drivers.  However, we need to register enough
minors so that we have all possible CPUs.

checkpatch warns on this patch, but the patch is correct: NR_CPUS here
is a static *upper bound* on the *maximum CPU index* (not *number of
CPUs!*) and that is what we want.

Reported-and-tested-by: Russ Anderson <rja@sgi.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Takashi Iwai <tiwai@suse.de>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
LKML-Reference: <tip-*@git.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
arch/x86/kernel/cpuid.c
arch/x86/kernel/msr.c