]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
fault-injection: fix failcmd.sh warning
authorAkinobu Mita <akinobu.mita@gmail.com>
Tue, 31 Jul 2012 23:41:31 +0000 (16:41 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Wed, 1 Aug 2012 01:42:38 +0000 (18:42 -0700)
commitd6b09e754c23b657544f6e7f39fbf7de24c58aa2
tree7f1128c531b80c968e503327f0d65b27cd3c3764
parent2e3ee613480563a6d5c01b57d342e65cc58c06df
fault-injection: fix failcmd.sh warning

"fault-injection: add tool to run command with failslab or
fail_page_alloc" added tools/testing/fault-injection/failcmd.sh to make it
easier to inject slab/page allocation failures by fault injection.

failcmd.sh prints the following warning when running with arguments
for command.

# ./failcmd.sh echo aaa
failcmd.sh: line 209: [: echo: binary operator expected
aaa

This warning is caused by an improper check whether at least one
parameter is left after parsing command options.

Fix it by testing the length of $1 instead of $@

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
tools/testing/fault-injection/failcmd.sh