]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
mtd: ichxrom: maybe-uninitialized with gcc-4.9
authorArnd Bergmann <arnd@arndb.de>
Mon, 24 Oct 2016 15:28:35 +0000 (17:28 +0200)
committerBrian Norris <computersforpeace@gmail.com>
Wed, 8 Feb 2017 22:13:05 +0000 (14:13 -0800)
commite70dda0868fad0f74c46df21f7f45fec24f29879
tree76091ac56597c5039b40718e451d79ab624e3a65
parent6080ef6e7c0a0592cbcca11200d879faf65e27d4
mtd: ichxrom: maybe-uninitialized with gcc-4.9

pci_read_config_word() might fail and not initialize its output,
as pointed out by older versions of gcc when using the -Wmaybe-unintialized
flag:

drivers/mtd/maps/ichxrom.c: In function ‘ichxrom_cleanup’:
drivers/mtd/maps/ichxrom.c:63:2: error: ‘word’ is used uninitialized in this function [-Werror=uninitialized]

This is apparently a correct warning, though it does not show up
with newer compilers. Changing the code to not attempt to write
back uninitialized data into PCI config space is a correct
fix for the problem and avoids the warning.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Marek Vasut <marex@denx.de>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
drivers/mtd/maps/ichxrom.c