]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
RDMA/ocrdma: Use unsigned for bit index
authorRasmus Villemoes <linux@rasmusvillemoes.dk>
Fri, 16 Jan 2015 14:39:56 +0000 (15:39 +0100)
committerRoland Dreier <roland@purestorage.com>
Wed, 18 Feb 2015 16:31:06 +0000 (08:31 -0800)
commitf3070e7efdc37a84fa63cbe84ac4febc87440121
tree95ca4251d6c867bb977203f4eaab3185b5a115a3
parentba64fdca63af5a1bdda8e33d9cc8496089631dde
RDMA/ocrdma: Use unsigned for bit index

In the expressions idx/32 and idx%32, both idx and 32 have signed
type, and unfortunately the C standard prescribes rounding to 0, so
unless gcc can prove that idx is non-negative, these cannot be
implemented as simple shift respectively mask operations. Help gcc by
changing the type of idx to unsigned - this cuts another few
instructions from the generated code.

Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Acked-by: Selvin Xavier <selvin.xavier@emulex.com>
Signed-off-by: Roland Dreier <roland@purestorage.com>
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c