]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
fs: Fix imbalance in freeze protection in mark_files_ro()
authorJan Kara <jack@suse.cz>
Wed, 5 Dec 2012 13:40:14 +0000 (14:40 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Jan 2013 17:19:02 +0000 (09:19 -0800)
commitff68026c74ea60403004010c4cc1f81b1f4faa2a
tree3b8f5c5f56733d5df3b947acd8c4553385b1eda8
parentbbe614b3f9a1cab9cdd88ecdd9415bd3dd04efd3
fs: Fix imbalance in freeze protection in mark_files_ro()

commit 72651cac884b1e285fa8e8314b10e9f1b8458802 upstream.

File descriptors (even those for writing) do not hold freeze protection.
Thus mark_files_ro() must call __mnt_drop_write() to only drop protection
against remount read-only. Calling mnt_drop_write_file() as we do now
results in:

[ BUG: bad unlock balance detected! ]
3.7.0-rc6-00028-g88e75b6 #101 Not tainted
-------------------------------------
kworker/1:2/79 is trying to release lock (sb_writers) at:
[<ffffffff811b33b4>] mnt_drop_write+0x24/0x30
but there are no more locks to release!

Reported-by: Zdenek Kabelac <zkabelac@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/file_table.c