]> git.kernelconcepts.de Git - karo-tx-linux.git/commit
md: protect against crash upon fsync on ro array
authorSebastian Riemer <sebastian.riemer@profitbricks.com>
Thu, 21 Feb 2013 02:28:09 +0000 (13:28 +1100)
committerBen Hutchings <ben@decadent.org.uk>
Wed, 20 Mar 2013 15:03:15 +0000 (15:03 +0000)
commitff891f9e86ca1e125b3d07c78413a4c1dbb6ca8a
tree3ba14784cd4c5056ea72a3251ee548a0b1f3618d
parent554995ab65f98584d95e06e4d44f0c4d3293cee7
md: protect against crash upon fsync on ro array

commit bbfa57c0f2243a7c31fd248d22e9861a2802cad5 upstream.

If an fsync occurs on a read-only array, we need to send a
completion for the IO and may not increment the active IO count.
Otherwise, we hit a bug trace and can't stop the MD array anymore.

By advice of Christoph Hellwig we return success upon a flush
request but we return -EROFS for other writes.
We detect flush requests by checking if the bio has zero sectors.

This patch is suitable to any -stable kernel to which it applies.

Cc: Christoph Hellwig <hch@infradead.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: NeilBrown <neilb@suse.de>
Signed-off-by: Sebastian Riemer <sebastian.riemer@profitbricks.com>
Reported-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Paul Menzel <paulepanter@users.sourceforge.net>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/md/md.c