]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
Input: ims-pcu - fix uninitialized use of 'error' in ims_pcu_buffers_alloc()
authorChristian Engelmayer <cengelma@gmx.at>
Sun, 18 May 2014 23:00:40 +0000 (16:00 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 19 May 2014 05:39:56 +0000 (22:39 -0700)
In case allocation via usb_alloc_coherent() fails in ims_pcu_buffers_alloc(),
the function jumps to the exit path without initializing local variable
'error' that is used as return value. Detected by Coverity - CID 1016531.

Signed-off-by: Christian Engelmayer <cengelma@gmx.at>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/misc/ims-pcu.c

index 5a736397d9c8ee3f540ce9cc7b7f77710ff6b787..719410feb84bf9521e94fad32d299e890c1b210b 100644 (file)
@@ -1566,6 +1566,7 @@ static int ims_pcu_buffers_alloc(struct ims_pcu *pcu)
        if (!pcu->urb_ctrl_buf) {
                dev_err(pcu->dev,
                        "Failed to allocate memory for read buffer\n");
+               error = -ENOMEM;
                goto err_free_urb_out_buf;
        }