]> git.kernelconcepts.de Git - karo-tx-linux.git/commitdiff
drivers: usb-misc: sisusbvga: remove dead code
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Wed, 8 Feb 2017 04:01:35 +0000 (22:01 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 8 Feb 2017 06:43:47 +0000 (07:43 +0100)
The condition modex % 16 cannot be true when modex value is equal to 640
The condition du & 0xff cannot be true when du value is equal to 0x1400

Addresses-Coverity-Id: 101163
Addresses-Coverity-Id: 744373
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/misc/sisusbvga/sisusb.c

index 05bd39d62568198bc5ff5e6e0dc59910e279a677..440d7fef58cc6d18f1b7e55f96ddba63b0a97043 100644 (file)
@@ -1831,16 +1831,10 @@ static int sisusb_set_default_mode(struct sisusb_usb_data *sisusb,
        SETIREGANDOR(SISCR, 0x09, 0x5f, ((crtcdata[16] & 0x01) << 5));
        SETIREG(SISCR, 0x14, 0x4f);
        du = (modex / 16) * (bpp * 2);  /* offset/pitch */
-       if (modex % 16)
-               du += bpp;
-
        SETIREGANDOR(SISSR, 0x0e, 0xf0, ((du >> 8) & 0x0f));
        SETIREG(SISCR, 0x13, (du & 0xff));
        du <<= 5;
        tmp8 = du >> 8;
-       if (du & 0xff)
-               tmp8++;
-
        SETIREG(SISSR, 0x10, tmp8);
        SETIREG(SISSR, 0x31, 0x00);     /* VCLK */
        SETIREG(SISSR, 0x2b, 0x1b);